Skip to content

test: add aggregate fuzz tests for all shapes - #24881

Draft
rluvaton wants to merge 1 commit into
apache:mainfrom
rluvaton:fuzz-test-aggregation-all-cases
Draft

test: add aggregate fuzz tests for all shapes#24881
rluvaton wants to merge 1 commit into
apache:mainfrom
rluvaton:fuzz-test-aggregation-all-cases

Conversation

@rluvaton

@rluvaton rluvaton commented Sep 2, 2026

Copy link
Copy Markdown
Member

Which issue does this PR close?

N/A

Rationale for this change

There is no test that verify that we produce the same output in all cases of the extracted aggregate streams
and we are still doing refactor there so this increase the coverage

What changes are included in this PR?

added fuzz tests on all shapes of plan and cardinality, group by columns, mem, etc

What is the testing strategy for this PR?

added

Are there any user-facing changes?

no

@github-actions github-actions Bot added core Core DataFusion crate functions Changes to functions implementation physical-plan Changes to the physical-plan crate labels Sep 2, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.62%. Comparing base (3a4c310) to head (3613439).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...hysical-plan/src/aggregates/grouped_hash_stream.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24881      +/-   ##
==========================================
- Coverage   81.62%   81.62%   -0.01%     
==========================================
  Files        1123     1123              
  Lines      409637   409539      -98     
  Branches   409637   409539      -98     
==========================================
- Hits       334383   334291      -92     
+ Misses      55624    55605      -19     
- Partials    19630    19643      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tschwarzinger pushed a commit to tschwarzinger/datafusion that referenced this pull request Sep 3, 2026
## Which issue does this PR close?
N/A

## Rationale for this change
after emit all, the memory is still being held in count distinct causing
OOM issues

## What changes are included in this PR?
release memory in emit all and added tests

## What is the testing strategy for this PR?
integration test

## Are there any user-facing changes?
no

----


Founded while running:
- apache#24881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate functions Changes to functions implementation physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants