Skip to content

Fix project scoped network filtering during unmanaged instance import - #14008

Open
dheeraj12347 wants to merge 1 commit into
apache:4.22from
dheeraj12347:fix-import-network-scope-4.22
Open

Fix project scoped network filtering during unmanaged instance import#14008
dheeraj12347 wants to merge 1 commit into
apache:4.22from
dheeraj12347:fix-import-network-scope-4.22

Conversation

@dheeraj12347

Copy link
Copy Markdown
Contributor

Description

Fix network selection for project-scoped unmanaged instance imports.

When importing an unmanaged instance from a project scope, the network selection component was not receiving the project ID. As a result, listNetworks could fall back to account/domain-based filtering instead of retrieving networks for the selected project.

This change passes the project ID to MultiNetworkSelection and uses it when fetching networks.

Changes

  • Pass form.projectid from ImportUnmanagedInstance.vue to MultiNetworkSelection.
  • Add projectid as an optional prop to MultiNetworkSelection.
  • Refresh the available networks when the project ID changes.
  • Use projectid for the listNetworks API request when a project scope is selected.
  • Preserve the existing domainid + account behavior when no project ID is provided.
  • Add unit tests covering project-scoped and account/domain-scoped network requests and project changes.

Testing

  • git diff --check passes.
  • Added unit coverage for the new project-scoped network filtering behavior.
  • Full UI unit-test execution could not be run locally because the UI dependencies are not installed in the current environment.

Related

Fixes the project-scoped network selection issue during unmanaged instance import.

@dheeraj12347

Copy link
Copy Markdown
Contributor Author

Hi @DaanHoogland and @weizhouapache , quick update on the two PRs:

Please let me know if you’d like me to take any further action on either PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant