You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix network selection for project-scoped unmanaged instance imports.
When importing an unmanaged instance from a project scope, the network selection component was not receiving the project ID. As a result, listNetworks could fall back to account/domain-based filtering instead of retrieving networks for the selected project.
This change passes the project ID to MultiNetworkSelection and uses it when fetching networks.
Changes
Pass form.projectid from ImportUnmanagedInstance.vue to MultiNetworkSelection.
Add projectid as an optional prop to MultiNetworkSelection.
Refresh the available networks when the project ID changes.
Use projectid for the listNetworks API request when a project scope is selected.
Preserve the existing domainid + account behavior when no project ID is provided.
Add unit tests covering project-scoped and account/domain-scoped network requests and project changes.
Testing
git diff --check passes.
Added unit coverage for the new project-scoped network filtering behavior.
Full UI unit-test execution could not be run locally because the UI dependencies are not installed in the current environment.
Related
Fixes the project-scoped network selection issue during unmanaged instance import.
Fix project scoped network filtering during unmanaged instance import #14008 — I’ve opened the focused fix for the project-scoped network filtering issue during unmanaged instance import. The changes pass projectid through to MultiNetworkSelection and use it for the listNetworks request while preserving the existing account/domain behavior. The PR currently has no merge conflicts and is waiting for CI/review.
Please let me know if you’d like me to take any further action on either PR.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix network selection for project-scoped unmanaged instance imports.
When importing an unmanaged instance from a project scope, the network selection component was not receiving the project ID. As a result,
listNetworkscould fall back to account/domain-based filtering instead of retrieving networks for the selected project.This change passes the project ID to
MultiNetworkSelectionand uses it when fetching networks.Changes
form.projectidfromImportUnmanagedInstance.vuetoMultiNetworkSelection.projectidas an optional prop toMultiNetworkSelection.projectidfor thelistNetworksAPI request when a project scope is selected.domainid+accountbehavior when no project ID is provided.Testing
git diff --checkpasses.Related
Fixes the project-scoped network selection issue during unmanaged instance import.