Skip to content

License: updates per the 2.2.0 RC3 review - #133

Merged
tuhaihe merged 2 commits into
apache:mainfrom
tuhaihe:license-postgresql
Nov 4, 2026
Merged

tuhaihe merged 2 commits into
apache:mainfrom
tuhaihe:license-postgresql

Conversation

@tuhaihe

@tuhaihe tuhaihe commented Nov 2, 2026

Copy link
Copy Markdown
Member

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist

Here are some reminders before you submit your pull request:

@tuhaihe tuhaihe changed the title License: udpates per the 2.2.0 RC3 review License: updates per the 2.2.0 RC3 review Nov 2, 2026
@tuhaihe
tuhaihe requested a review from leborchuk November 3, 2026 03:33
Several catalog queries and helper functions say in their comments that
they are copied or adapted from PostgreSQL's pg_dump and psql:
queries_shared.go notes that the queries in backup/queries_*.go are
partly copied from pg_dump largely unmodified, predata_relations.go
derives from dumpSequence(), utils/util.go follows
appendStringLiteralDQ(), and an end-to-end test is borrowed from
PostgreSQL's pg_dump TAP tests.  All of this came in with Greenplum
Database Backup.  LICENSE did not mention PostgreSQL.  Ed Espino
pointed this out in the 2.2.0-incubating-rc3 IPMC vote.

List these files, with the PostgreSQL License text, as part of the
Greenplum Database Backup section.

Assisted-by: Claude Code
The Greenplum file list in LICENSE named show_coverage.go, but the file
is show_coverage.sh.  Jean-Baptiste Onofre pointed this out in the
2.2.0-incubating-rc3 IPMC vote.

Assisted-by: Claude Code
@tuhaihe
tuhaihe force-pushed the license-postgresql branch from 99370ba to 970543c Compare November 4, 2026 02:08
@tuhaihe
tuhaihe enabled auto-merge (rebase) November 4, 2026 02:09
@tuhaihe
tuhaihe merged commit ac1d5d8 into apache:main Nov 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants