[CALCITE-6648] IGNORE NULLS / RESPECT NULLS window function option can result in a type validation error in SqlToRelConverter - #5209
Merged
Conversation
mihaibudiu
reviewed
Aug 24, 2026
| * IGNORE NULLS / RESPECT NULLS window function option can result in a type | ||
| * validation error in SqlToRelConverter</a>. | ||
| * | ||
| * <p>When the input to the window function is a non-nullable type, the null |
Contributor
There was a problem hiding this comment.
Since the issue is solved I am not entirely sure what the point of the second part of this comment (and the one below) is.
Member
Author
There was a problem hiding this comment.
You're right; this comment is unnecessary, and I'll remove it later.
mihaibudiu
approved these changes
Aug 24, 2026
…n result in a type validation error in SqlToRelConverter
xuzifu666
force-pushed
the
calcite-6648
branch
from
August 25, 2026 15:19
c74457d to
35849dc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-6648
Based on the Jira discussion, complete test cases demonstrating the issue were not provided at the time; I have since added the relevant tests, and it appears the issue is now resolved.