Skip to content

Fix Dataflow job file validation on Windows - #39708

Open
ulofiai wants to merge 1 commit into
apache:masterfrom
ulofiai:fix/issue-18734
Open

Fix Dataflow job file validation on Windows#39708
ulofiai wants to merge 1 commit into
apache:masterfrom
ulofiai:fix/issue-18734

Conversation

@ulofiai

@ulofiai ulofiai commented Aug 11, 2026

Copy link
Copy Markdown

Fixes #18734.

Use File.isAbsolute() when validating dataflowJobFile and templateLocation. This accepts Windows drive-letter and UNC paths while preserving the existing Unix absolute-path and gs:// checks.

Signed-off-by: ulofiai <monsterking@tutamail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @jrmccluskey added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey jrmccluskey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any existing test cases that are disabled on windows that we could use to validate the fix here? Or can we refactor a bit to make unit testing more viable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Impossible to submit Google Dataflow job from Windows machine

2 participants