Repository navigation
Fix block comments ending in **/ - #445
Open
HoneyPaptan wants to merge 1 commit into
Open
HoneyPaptan wants to merge 1 commit into
HoneyPaptan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A block comment whose closing
*/is preceded by another*, such as/** doc **/or/***/, is never seen as closed. After a*that is not followed by/, the scanner steps past that next character, so the*of**/is skipped and the comment runs to the end of input:Both the Go parser and the npm version now check a
*again when the previous*did not close the comment.Verified on Go 1.27.1 / Linux amd64:
/** comment **/,/***/,{"a":1 /* comment **/}) fail before the change with "Unexpected end of input in comment" and pass after it. Unclosed comments such as/*/ "test"and/* test *still fail.go test ./...,go vetandcd npm && node test.jspass;gofmt -lis clean.