Repository navigation
Preserve array indexes when serializing query results - #443
Open
nk-batman21 wants to merge 1 commit into
Open
nk-batman21 wants to merge 1 commit into
nk-batman21 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting an array element in a query changes later indexes in the JSON output:
This currently produces
[1,3]instead of[1,null,3]. The serializer enumerates the array's own keys, so holes disappear, non-enumerable indexes are omitted, and extra named properties become array elements.Serialize indexes from zero to the array's length and write missing values as null. This fixes both compact query output and the indented serializer used by
save(). Tests compare five affected arrays againstJSON.stringifyin both modes.Validation: all five cases fail on the unchanged base. The full Go suite passes on Linux; the engine suite,
go vet ./internal/engine, and a built CLI reproduction pass on Windows.