Repository navigation
Return an empty array when zip has no inputs - #442
Open
nk-batman21 wants to merge 1 commit into
Open
nk-batman21 wants to merge 1 commit into
nk-batman21 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transposing an empty array with
fx 'x => zip(...x)'never finishes. With no input arrays,Math.min()producesInfinity, sozipkeeps appending empty arrays. The Go preview eventually times out; the CLI and npm version keep running.Return an empty array before entering the loop when no arrays were passed. Apply the same fix to both runtimes. Regressions run the actual transformation in the Go engine and the npm CLI, with a timeout so the old behavior cannot hang the test suite.
Validation: both regressions fail on the unchanged base. The full Go suite and all 37 npm tests pass on Linux; the engine suite,
go vet ./internal/engine, and a built CLI smoke test pass on Windows.