Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed YAML, TOML, or XML can fail while
newParserinitializes, before the normal evaluation error path. That startup branch prints the diagnostic to stdout, contaminating the stream used for results.Write the existing error text to stderr instead. The text and exit status remain unchanged. The regression runs the CLI through its existing test-binary entry point and checks stdout, stderr, and exit status for all three formats.
Validation on Go 1.26.0 / Linux amd64:
go test -count=1 ./...andgo vet ./...pass.TestGotoLineKeepsHistorygolden-output failure; that test subsequently passed 20 repetitions on both clean base and the patch, and the complete Go suite passed on rerun.cd npm && node test.jsfails at its first formatting assertion in this environment on both clean base and the patch (empty stdout). The npm sources are unchanged.The ARM CI job has not been run locally.