You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@antecedent Interesting. I'd run the tests locally on Windows with PHP 8.6-beta1 with a php.ini based on the php.ini-development file and the tests were passing fine.
And while I'm writing this, I remember that shivammathur/setup-php uses the php.ini-production file as default, so it makes total sense that the ini values for the settings being changed in this PR would be turned off for production.
In other words, an alternative solution would probably be to add ini-file: development to the with section of the Setup PHP step.
@jrfnl, I think that is great! I do prefer having the php.ini values set in a more across-the-board way. But it was not enough to set ini-file: development; I ended up adding the setting to ini-values separately. That is still an improvement to me. But I wonder how come you got a different default from the php.ini-development on your local setup 👀
But I wonder how come you got a different default from the php.ini-development on your local setup 👀
I wondered too and just did a compare between the php.ini-develop and php.ini for PHP 8.6-beta1 on my machine and yes, you're right, it's not standard and I'd clearly forgotten that I'd turned it on 🙈. Blame chemo-brain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to bring #217 to completion. I merged that one prematurely; the test case had not been passing.