Repository navigation
fix(core): only discourage unprompted subagent status checks - #63662
Merged
Merged
Conversation
There was a problem hiding this comment.
The wording change looks good: it's consistent across the tool description, the background result and the mini demo copy, and no copies of the old phrasing are left. The prompt still says that <subagent> messages arrive on their own and that the child can be messaged with its sessionID, so dropping the "topics" clause doesn't remove any guidance the model needs. tool-subagent.test.ts passes and tsc type-checks packages/core.
Public API is unchanged: only model-facing prompt text changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subagent tool told the model not to "ask the subagent for status", with no exception. A strict model could read that as "never message a running child", even when the user asks what it's doing. The point of the rule is to stop the model checking in on its own, so this says that instead.
I also dropped "avoid working with the same files or topics it is using". "Topics" is vague enough to stop the parent from doing related work like reviewing what the child changes, and the next line ("Work on non-overlapping tasks") already covers stepping on the child's files. The "you'll receive a
<subagent>message" and "call subagent again with this sessionID" lines are unchanged, so the model still knows results arrive on their own and that messaging the child is allowed.The mini TUI demo's copy of the launch text is updated to match.
Checked:
bun test test/tool-subagent.test.ts(15 pass) andbun typecheckin packages/core.