Repository navigation
docs(protocol): describe parentID on session create - #63653
Merged
Merged
Conversation
There was a problem hiding this comment.
Docs-only change that looks good. I checked the new parentID description against the code:
- When
parentIDis set, the server handler dropslocation, so the child runs at the parent's location. - The child's report reaches the parent's inbox as a
<subagent>message. - The parent is only woken when it has no staged revert.
The regenerated openapi.json matches the schema annotation.
Public API: unchanged. Only a field description is added to the session.create request schema in the OpenAPI spec; no fields, types or behaviour change.
No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
requested by dax.
Type of change
What does this PR do?
explains how to start a child session and when it reports back, right on the
parentIDfield in the api spec.How did you verify your code works?
regenerated the spec and clients, checked the generated spec, and ran the protocol typecheck.
Screenshots / recordings
n/a
Checklist
— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊