Skip to content

fix(tui): keep the Mini draft caret when closing the command palette #63260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlongster merged 1 commit into from
Nov 12, 2026
+6 −8
Merged

fix(tui): keep the Mini draft caret when closing the command palette #63260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/tui/src/mini/footer.prompt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ export function createPromptState(input: PromptInput): PromptState {
history = createPromptHistory(input.history?.())
})
let draft: RunPrompt = { text: "", parts: [] }
let draftCursor = 0
let stash: RunPrompt = { text: "", parts: [] }
let area: TextareaRenderable | undefined
const measure = (text: string) => measureEditText(text, { widthMethod: renderer.widthMethod })
Expand Down Expand Up @@ -704,6 +705,7 @@ export function createPromptState(input: PromptInput): PromptState {
const restore = (value: RunPrompt, cursor = Infinity) => {
revision += 1
draft = promptCopy(value)
draftCursor = cursor
setShell(value.mode === "shell")
if (!area || area.isDestroyed) {
return
Expand All @@ -726,6 +728,7 @@ export function createPromptState(input: PromptInput): PromptState {
clearParts()
hide()
draft = emptyPrompt(shell())
draftCursor = 0
if (!area || area.isDestroyed) {
return
}
Expand Down Expand Up @@ -792,6 +795,7 @@ export function createPromptState(input: PromptInput): PromptState {
}

if (area && !area.isDestroyed) {
draftCursor = area.cursorOffset
area.off("line-info-change", scheduleRows)
}

Expand All @@ -809,7 +813,7 @@ export function createPromptState(input: PromptInput): PromptState {
return
}

restore(draft)
restore(draft, draftCursor)
refresh()
})
}
Expand Down Expand Up @@ -1353,6 +1357,7 @@ export function createPromptState(input: PromptInput): PromptState {
const submitPrompt = (next: RunPrompt, delivery: RunDelivery = "steer") => {
if (!area || area.isDestroyed) {
draft = promptCopy(next)
draftCursor = Infinity
}

if (visible()) {
Expand Down Expand Up @@ -1506,13 +1511,6 @@ export function createPromptState(input: PromptInput): PromptState {

hide()
prev = kind
if (kind !== "prompt") {
return
}

queueMicrotask(() => {
restore(draft)
})
})

return {
Expand Down
Loading