Skip to content

fix(core): skip counting bytes past the last newline #61449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreivince wants to merge 4 commits into
base: dev
Choose a base branch
from
+5 −4
Open

fix(core): skip counting bytes past the last newline #61449

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
882a3c8
fix(core): avoid rebuilding long lines during file reads
andreivince Nov 3, 2026
deba206
Merge upstream dev into bounded-line-reader
andreivince Nov 13, 2026
42d0f0c
fix(core): skip counting bytes past the last newline
andreivince Nov 13, 2026
247e91c
Merge branch 'dev' into bounded-line-reader
andreivince Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/core/src/tool/read-filesystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,14 +274,15 @@ const textPage = Effect.fnUntraced(function* (
const nul = chunk.indexOf(0)
if (nul >= 0) firstNul = byte + nul
}
let count = 0
for (let i = 0; i < chunk.length; i++) count += Number(chunk[i] === 10)
if (count > 0) {
const lastNewline = chunk.lastIndexOf(10)
if (lastNewline >= 0) {
let count = 1
for (let i = 0; i < lastNewline; i++) count += Number(chunk[i] === 10)
const point = { byte, length: chunk.length, firstLine: total + 1, start, lastLine: total + count }
checkpoints.push(point)
total += count
if (requested > 0 && total >= requested) yield* collect(point, chunk)
start = byte + chunk.lastIndexOf(10) + 1
start = byte + lastNewline + 1
}
byte += chunk.length
// Any byte after a full page starts another line, even if that line has no newline for megabytes.
Expand Down
Loading