Nix checks do not run on v2 pull requests #52123

Activity

1. github-actions

   assigned

   Hona

   on Sep 29, 2026
2. github-actions

   added

   needs:complianceThis means the issue will auto-close after 2 hours.This means the issue will auto-close after 2 hours.

   on Sep 29, 2026
3. github-actions commented on Sep 29, 2026

   

   github-actionsBot

   on Sep 29, 2026 – with GitHub Actions

   Contributor

   More actions

   This issue doesn't fully meet our contributing guidelines.

   What needs to be fixed:

   • The issue doesn't use one of the required issue templates. Please use the Bug Report template, including its required Description field, and add brief reproduction steps for how the current workflow misses the desktop build failure.

   Please edit this issue to address the above within 2 hours, or it will be automatically closed.

   ---

   This issue might be a duplicate of existing issues. Please check:

   • #11755: A Nix desktop build failure that CI did not catch; the report suggests re-enabling a Nix desktop workflow.
   • #15400: A Nix build failure noting that nix-eval only evaluates derivations and does not run a build.

   If you believe this was flagged incorrectly, please let a maintainer know.
4. jerome-benoit

   changed the title [-]nix-eval.yml only runs on dev, so v2 packaging breakage goes unnoticed[/-] [+]Nix checks do not run on v2 pull requests[/+] on Sep 29, 2026
5. github-actions commented on Sep 29, 2026

   

   github-actionsBot

   on Sep 29, 2026 – with GitHub Actions

   Contributor

   More actions

   Thanks for adding context and reproduction steps. This issue still doesn't appear to use one of the required issue templates: please update it with the Bug Report template and include its required Description field with the issue details. The reproduction context you've added can remain.
6. github-actions

   removed

   needs:complianceThis means the issue will auto-close after 2 hours.This means the issue will auto-close after 2 hours.

   on Sep 29, 2026
7. github-actions commented on Sep 29, 2026

   

   github-actionsBot

   on Sep 29, 2026 – with GitHub Actions

   Contributor

   More actions

   Thanks for updating the issue with reproduction details and system information!
8. jerome-benoit commented on Oct 2, 2026

   

   jerome-benoit

   on Oct 2, 2026

   ContributorAuthor

   More actions

   Fixed upstream by #52143 (ec541abbcd), which added v2 to the nix-eval triggers:

   on:
     push:
       branches: [dev, v2]
     pull_request:
       branches: [dev, v2]

   Combined with #52129 (c34d09fe97), which unblocked flake evaluation on nixpkgs 26.11 and dropped the stale x86_64-darwin target, both defects reported here are addressed on v2.

   Remaining gap

   One point from this report is still open, tracked here for visibility rather than silently: nix-eval only evaluates drvPath and never builds, and nix-hashes.yml still has no pull_request trigger, so a stale fixed-output hash on nix/hashes.json is only caught after merge to v2. That is a separate change from the trigger fix above.
9. jerome-benoit

   closed this as completedon Oct 2, 2026
10. jerome-benoit commented on Oct 2, 2026

    

    jerome-benoit

    on Oct 2, 2026

    ContributorAuthor

    More actions

    Follow-up: the remaining gap from the closing comment is now tracked on its own — #52863.