Skip to content

perf(@angular/build): replace watchpack with @parcel/watcher and chokidar #33656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Aug 7, 2026
Merged

perf(@angular/build): replace watchpack with @parcel/watcher and chokidar #33656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@
"@types/picomatch": "^4.0.0",
"@types/progress": "^2.0.3",
"@types/semver": "^7.3.12",
"@types/watchpack": "^2.4.4",
"@types/yargs": "^17.0.20",
"@types/yargs-parser": "^21.0.0",
"@typescript-eslint/eslint-plugin": "8.66.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/build/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,11 @@ ts_project(
":node_modules/@babel/core",
":node_modules/@inquirer/confirm",
":node_modules/@oxc-project/types",
":node_modules/@parcel/watcher",
":node_modules/@vitejs/plugin-basic-ssl",
":node_modules/beasties",
":node_modules/browserslist",
":node_modules/chokidar",
":node_modules/https-proxy-agent",
":node_modules/istanbul-lib-instrument",
":node_modules/jsonc-parser",
Expand All @@ -108,7 +110,6 @@ ts_project(
":node_modules/tinyglobby",
":node_modules/vite",
":node_modules/vitest",
":node_modules/watchpack",
":node_modules/xxhash-wasm",
"//:node_modules/@angular/common",
"//:node_modules/@angular/compiler",
Expand All @@ -124,7 +125,6 @@ ts_project(
"//:node_modules/@types/node",
"//:node_modules/@types/picomatch",
"//:node_modules/@types/semver",
"//:node_modules/@types/watchpack",
"//:node_modules/esbuild",
"//:node_modules/esbuild-wasm",
"//:node_modules/karma",
Expand Down
3 changes: 2 additions & 1 deletion packages/angular/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@
"@angular-devkit/architect": "workspace:0.0.0-EXPERIMENTAL-PLACEHOLDER",
"@babel/core": "8.0.1",
"@inquirer/confirm": "6.1.1",
"@parcel/watcher": "2.6.0",
"@vitejs/plugin-basic-ssl": "2.3.0",
"beasties": "0.4.3",
"browserslist": "^4.26.0",
"chokidar": "5.0.0",
"esbuild": "0.28.1",
"https-proxy-agent": "9.1.0",
"jsonc-parser": "3.3.1",
Expand All @@ -41,7 +43,6 @@
"source-map-support": "0.5.21",
"tinyglobby": "0.2.17",
"vite": "8.2.0",
"watchpack": "2.5.2",
"xxhash-wasm": "1.1.0"
},
"optionalDependencies": {
Expand Down
7 changes: 6 additions & 1 deletion packages/angular/build/src/builders/application/build-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const packageWatchFiles = [
'.pnp.data.json',
];

// eslint-disable-next-line max-lines-per-function
export async function* runEsBuildBuildAction(
action: (rebuildState?: RebuildState) => Promise<ExecutionResult>,
options: {
Expand Down Expand Up @@ -116,11 +117,12 @@ export async function* runEsBuildBuildAction(

// Setup a watcher
const { createWatcher } = await import('../../tools/esbuild/watcher');
watcher = createWatcher({
watcher = await createWatcher({
polling: typeof poll === 'number',
interval: poll,
followSymlinks: preserveSymlinks,
ignored,
cwd: workspaceRoot,
});

// Setup abort support
Expand Down Expand Up @@ -218,6 +220,9 @@ export async function* runEsBuildBuildAction(
// Remove any stale locations if the build was successful
if (staleWatchFiles?.size) {
watcher.remove([...staleWatchFiles]);
for (const staleFile of staleWatchFiles) {
currentWatchFiles.delete(staleFile);
}
}

for (const outputResult of emitOutputResults(
Expand Down
Loading