Skip to content

Annotator silently fails on external rulesets #279

Open

Description

@rdicroce

PMDExternalAnnotator has a bug when used with external rulesets. If you want to use an external ruleset to validate Java files, then the ruleset's filename must have "java" in it. Otherwise the ruleset is silently ignored.

This is because of PMDExternalAnnotator#isRuleSetForGivenFile(). It would be better to do this filtering in some other way. Perhaps by removing the filtering altogether and making the annotation rulesets list be per-language, so the user can configure each language independently.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions