-
Notifications
You must be signed in to change notification settings - Fork 500
Decouple and minimize atelet/ateom shared paths #1604
Copy link
Copy link
Labels
area/api-machineryarea/nodekind/cleanupSmall fixes that are not bugs, for example a typo in a code commentSmall fixes that are not bugs, for example a typo in a code commentprio/P0Highest priority / required for next milestoneHighest priority / required for next milestone
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
area/api-machineryarea/nodekind/cleanupSmall fixes that are not bugs, for example a typo in a code commentSmall fixes that are not bugs, for example a typo in a code commentprio/P0Highest priority / required for next milestoneHighest priority / required for next milestone
Type
Projects
- StatusShow more project fieldsDone
Problem
Today ateom and atelet compute many per-actor directory paths from
actorUIDthrough the sameinternal/ateompathpackage.Theses directories are only created and wiped by atelet, and the RPC request between atelet/ateom only carries
actorUIDinstead of these directory paths so ateom has to recompute the paths on its end.Proposal
atelet owns the
actorUIDrelated paths and passes it in the RPCs. Can wrap them in a message (e.g.ActorDirs) and pass it to atelet RPCs.These directories are read or writes in ateom as a whole. For per-item paths like pid file ateom can still compute from directory+name, both from the request instead of shared path logic.
We still need to keep some shared paths for atelet/ateom: per-ateom directory and socket, the netns name, the credential broker socket and the OLTP socket.