Skip to content

Harmonize Python commands a little - #1528

Open
MaximeBICMTL wants to merge 1 commit into
aces:mainfrom
MaximeBICMTL:more-argparse
Open

MaximeBICMTL wants to merge 1 commit into
aces:mainfrom
MaximeBICMTL:more-argparse

Conversation

@MaximeBICMTL

@MaximeBICMTL MaximeBICMTL commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description

  • Adopt argparse rather than LorisGetOpt in the DICOM study importer and the BIDS dataset importer.
  • Change some CLI options more intuitive.
  • Rename some scripts for better consistency.
  • Improve make_env to take an argparse.Namespace as an argument rather than the LorisGetOpt dictionary.

Breaking changes

DICOM study importer:

  • Pass the DICOM study as a positional argument rather than --source.
  • Remove the --insert CLI flag, insertion is the default, can be changed by using the --update CLI flag.
  • Remove the --session CLI flag, session association is the default, can be disabled by using the new --no-session CLI flag.

BIDS dataset importer:

  • Pass the BIDS dataset as a positional argument rather than --directory.

Other scripts:

  • Rename the mass_electrophysiology_chunking.py command to create-ephys-chunks.
  • Rename the mass_nifti_pic.py command to create-nifti-pic.

@github-actions github-actions Bot added Language: Perl Issue or PR related to the Perl codebase Language: Python Issue or PR related to the Python codebase Package: BIDS importer PR or issue related to the BIDS importer Package: DICOM importer PR or issue related to the DICOM importer Package: DICOM to BIDS converter PR or issue related to the DICOM to BIDS converter labels Nov 15, 2026
@MaximeBICMTL MaximeBICMTL changed the title Adopt argparse in more scripts Harmonize Python commands a little Nov 15, 2026
@MaximeBICMTL MaximeBICMTL added Caveat for Existing Projects Issue or PR that introduces or may introduce breaking changes for existing projects Category: Refactor Issue or PR that aims to improve the existing code Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test labels Nov 15, 2026
@MaximeBICMTL
MaximeBICMTL marked this pull request as ready for review November 15, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Refactor Issue or PR that aims to improve the existing code Caveat for Existing Projects Issue or PR that introduces or may introduce breaking changes for existing projects Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test Language: Perl Issue or PR related to the Perl codebase Language: Python Issue or PR related to the Python codebase Package: BIDS importer PR or issue related to the BIDS importer Package: DICOM importer PR or issue related to the DICOM importer Package: DICOM to BIDS converter PR or issue related to the DICOM to BIDS converter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant