Skip to content

feat: add launch_origin_id advarg to mister.script - #82

Merged
wizzomafizzo merged 1 commit into
mainfrom
feat/mister-script-launch-origin
Sep 24, 2026
Merged

wizzomafizzo merged 1 commit into
mainfrom
feat/mister-script-launch-origin

Conversation

@wizzomafizzo

@wizzomafizzo wizzomafizzo commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Adds launch_origin_id to MisterScriptArgs, e.g. **mister.script:update_all.sh?launch_origin_id=zaparoo_frontend. Core sets LAUNCH_ORIGIN_ID to the given value in the script's environment and leaves it unset when the arg is absent.

Needed by ZaparooProject/zaparoo-core#1551.

Summary by CodeRabbit

  • New Features
    • Scripts can now receive a launch origin ID through the LAUNCH_ORIGIN_ID environment variable when one is provided. When no launch origin ID is supplied, the variable remains unset. This allows scripts to access the launch origin associated with a run without changing behavior for runs that do not have one.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d1f0e631-7e89-459a-90b6-b81aa1eaa480

📥 Commits

Reviewing files that changed from the base of the PR and between f916eec and 543b98c.

📒 Files selected for processing (2)
  • types.go
  • types_advargs_test.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

MisterScriptArgs gains a LaunchOriginID field tagged as launch_origin_id. A test verifies that the field has the expected advarg tag.

Changes

Launch origin argument

Layer / File(s) Summary
Add and test launch origin field
types.go, types_advargs_test.go
MisterScriptArgs declares LaunchOriginID with the launch_origin_id advarg tag. A test verifies the field and tag.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 543b9

The new field makes launch-origin metadata available to the Core consumer. No concrete merge-blocking failure is established for this change.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the launch_origin_id advarg to mister.script.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wizzomafizzo
wizzomafizzo merged commit d18eb0d into main Sep 24, 2026
12 checks passed
@wizzomafizzo
wizzomafizzo deleted the feat/mister-script-launch-origin branch September 24, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant