feat: add launch_origin_id advarg to mister.script - #82
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughMisterScriptArgs gains a LaunchOriginID field tagged as launch_origin_id. A test verifies that the field has the expected advarg tag. ChangesLaunch origin argument
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The new field makes launch-origin metadata available to the Core consumer. No concrete merge-blocking failure is established for this change. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Adds
launch_origin_idtoMisterScriptArgs, e.g.**mister.script:update_all.sh?launch_origin_id=zaparoo_frontend. Core setsLAUNCH_ORIGIN_IDto the given value in the script's environment and leaves it unset when the arg is absent.Needed by ZaparooProject/zaparoo-core#1551.
Summary by CodeRabbit
LAUNCH_ORIGIN_IDenvironment variable when one is provided. When no launch origin ID is supplied, the variable remains unset. This allows scripts to access the launch origin associated with a run without changing behavior for runs that do not have one.