Skip to content

fix: pass slash trigger context to provider catalogs - #854

Open
SkyNotSilent wants to merge 1 commit into
YishenTu:mainfrom
SkyNotSilent:codex/codex-provider-slash-context
Open

fix: pass slash trigger context to provider catalogs#854
SkyNotSilent wants to merge 1 commit into
YishenTu:mainfrom
SkyNotSilent:codex/codex-provider-slash-context

Conversation

@SkyNotSilent

@SkyNotSilent SkyNotSilent commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass slash dropdown trigger context through the shared provider command catalog interface.
  • Allow provider catalogs to receive both includeBuiltIns and triggerChar so providers can distinguish / from $ when needed.
  • Allow Codex provider slash built-ins such as /compact to appear when the composer is triggered with / at the start of the input.
  • Keep $ scoped to Codex skills so $skill completion does not mix in slash-only provider commands.

Why

Provider-native command discovery should be decided by the provider catalog, while the shared dropdown should supply the trigger context. Previously the dropdown wrapper always requested provider entries with includeBuiltIns: false, so Codex-native slash commands such as /compact were not discoverable even though sending /compact manually worked.

This keeps Claudian-local commands such as /clear handled locally, while provider-native commands and skills are exposed through the correct trigger namespace. Providers that only use / can ignore triggerChar; providers with multiple trigger namespaces can now make that decision at the catalog boundary.

Related context checked

Validation

  • npm run test -- --selectProjects unit --runTestsByPath tests/unit/shared/components/SlashCommandDropdown.provider.test.ts tests/unit/features/chat/tabs/TabManager.test.ts tests/unit/providers/codex/commands/CodexSkillCatalog.test.ts tests/unit/providers/claude/commands/ClaudeCommandCatalog.test.ts tests/unit/providers/pi/commands/PiCommandCatalog.test.ts tests/unit/providers/opencode/OpencodeCommandCatalog.test.ts --runInBand
  • npm run typecheck
  • npm run lint
  • npm run test -- --runInBand
  • npm run build
  • git diff --check

@SkyNotSilent
SkyNotSilent force-pushed the codex/codex-provider-slash-context branch from 88f34fa to e1d9652 Compare July 3, 2026 15:05
@SkyNotSilent SkyNotSilent changed the title [codex] fix Codex slash dropdown provider context fix: pass slash trigger context to provider catalogs Jul 3, 2026
@SkyNotSilent
SkyNotSilent marked this pull request as ready for review July 3, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant