fix: pass slash trigger context to provider catalogs - #854
Open
SkyNotSilent wants to merge 1 commit into
Open
Conversation
SkyNotSilent
force-pushed
the
codex/codex-provider-slash-context
branch
from
July 3, 2026 15:05
88f34fa to
e1d9652
Compare
SkyNotSilent
marked this pull request as ready for review
July 3, 2026 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includeBuiltInsandtriggerCharso providers can distinguish/from$when needed./compactto appear when the composer is triggered with/at the start of the input.$scoped to Codex skills so$skillcompletion does not mix in slash-only provider commands.Why
Provider-native command discovery should be decided by the provider catalog, while the shared dropdown should supply the trigger context. Previously the dropdown wrapper always requested provider entries with
includeBuiltIns: false, so Codex-native slash commands such as/compactwere not discoverable even though sending/compactmanually worked.This keeps Claudian-local commands such as
/clearhandled locally, while provider-native commands and skills are exposed through the correct trigger namespace. Providers that only use/can ignoretriggerChar; providers with multiple trigger namespaces can now make that decision at the catalog boundary.Related context checked
/compactdiscovery.SlashCommandDropdownfor exact-match sorting, but this PR changes provider-entry context propagation rather than result ranking.Validation
npm run test -- --selectProjects unit --runTestsByPath tests/unit/shared/components/SlashCommandDropdown.provider.test.ts tests/unit/features/chat/tabs/TabManager.test.ts tests/unit/providers/codex/commands/CodexSkillCatalog.test.ts tests/unit/providers/claude/commands/ClaudeCommandCatalog.test.ts tests/unit/providers/pi/commands/PiCommandCatalog.test.ts tests/unit/providers/opencode/OpencodeCommandCatalog.test.ts --runInBandnpm run typechecknpm run lintnpm run test -- --runInBandnpm run buildgit diff --check