feat: BILLS-6409 updated /invoices endpoints with RoundingAmount and EnteredTotal - #847
Closed
sli-o1 wants to merge 3 commits into
Closed
feat: BILLS-6409 updated /invoices endpoints with RoundingAmount and EnteredTotal#847sli-o1 wants to merge 3 commits into
sli-o1 wants to merge 3 commits into
Conversation
… EnteredTotal fields in API contracts for ACCPAY and ACCREC document types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The newly exposed fields are available to PUT/POST/GET by ID endpoints for ACCPAY and ACCREC document types.
Validations are only in place for SUBMITTED/AUTHORISED documents if the supplied API requests come with all 3 of total, totalTax and subTotal.
RoundingAmount would be persisted if it is within +/- $0.10 (inclusive).
EnteredTotal would be persisted without validations if document is in DRAFT. User supplied values for EnteredTotal are ignored if document is in SUBMITTED/AUTHORISED.