Skip to content

Unpin Gradle, Java and Docker steps - #791

Open
Kichura wants to merge 4 commits into
ViaVersion:mainfrom
Kichura:rs_fun_pkg
Open

Kichura wants to merge 4 commits into
ViaVersion:mainfrom
Kichura:rs_fun_pkg

Conversation

@Kichura

@Kichura Kichura commented Oct 2, 2026

Copy link
Copy Markdown
Member

setup-gradle, setup-java and docker's actions are immutable meaning they no longer need to be pinned, unfortunately checkout and upload-artifact still suffer from possible supply chain attacks whereas crowdin needs a new release to be considered immutable.

@Kichura Kichura added the github_actions Pull requests that update GitHub Actions code label Oct 2, 2026
@RaphiMC

RaphiMC commented Oct 3, 2026

Copy link
Copy Markdown
Member

Valid changes, but I will hold of with merging it, until all of the used actions have immutable releases

@Kichura

Kichura commented Oct 4, 2026

Copy link
Copy Markdown
Member Author

Valid changes, but I will hold of with merging it, until all of the used actions have immutable releases

I don't think GitHub themselves will care about it given that they are known for ignoring people's warnings all together, especially the checkout's persist-credentials boolean.

@Kichura

Kichura commented Oct 13, 2026 •

Copy link
Copy Markdown
Member Author

I don't think GitHub themselves will care about it given that they are known for ignoring people's warnings all together, especially the checkout's persist-credentials boolean.

Looked into v7.0.2 of upload-artifact and it's not immutable, so my theory is correct.

@RaphiMC

RaphiMC commented Oct 30, 2026

Copy link
Copy Markdown
Member

Is there actually any reason to switch back to version tags for half of the actions, when dependabot is updating/maintaining them anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants