Fix k_nSteamNetworkingSend_UnreliableNoDelay docs to match actual behavior - #426
Open
ResakaGit wants to merge 1 commit into
Open
Fix k_nSteamNetworkingSend_UnreliableNoDelay docs to match actual behavior#426ResakaGit wants to merge 1 commit into
ResakaGit wants to merge 1 commit into
Conversation
…avior The documentation promised that a message would be dropped if enough data was already queued that it would not be placed on the wire in the next ~200ms or so. That check was never implemented (there is a FIXME in SNP_SendMessage), so the docs now describe what actually happens: the message is only dropped while the connection is not fully connected; otherwise it is queued as usual, subject to the ordinary send buffer limit. Fixes ValveSoftware#399 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for k_nSteamNetworkingSend_UnreliableNoDelay promise that a message will be dropped if enough data is already queued that it would not be placed on the wire in the next ~200ms or so. As reported in #399, that check was never implemented (there is a FIXME in SNP_SendMessage), so this updates the comment to describe what actually happens: the message is only dropped while the connection is not fully connected (returning k_EResultIgnored); otherwise it is queued as usual, subject to the ordinary send buffer limit.
Fixes #399
🤖 Generated with Claude Code