Skip to content

Handle CLI service errors consistently - #2508

Merged
adamtheturtle merged 6 commits into
mainfrom
codex/fix-cli-error-handling
Aug 26, 2026
Merged

Handle CLI service errors consistently#2508
adamtheturtle merged 6 commits into
mainfrom
codex/fix-cli-error-handling

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

  • provide explicit messages and a generic fallback for VWS, Cloud Reco, and Model Target service errors
  • route report authentication and polling timeouts through the shared handler
  • accurately describe targets whose status is not Success
  • test supported error responses through public CLI commands backed by MockVWS, without patching client methods or importing private formatters
  • update vws-python-mock to 2026.8.26 for configurable Cloud Query and VuMark failures
  • send the Model Target API's required views array and match shared standard/advanced dataset visibility
  • retain defensive Model Target fallbacks until the linked upstream capabilities are released

Testing

  • uv run prek run --all-files --hook-stage pre-commit
  • uv run pytest -s -q --cov-fail-under 100 --cov=src/ --cov=tests . (151 passed, 100% branch coverage)
  • mypy, pyright, pyrefly, and ty

Follow-up tracking

Closes #2487
Closes #2488
Closes #2489
Closes #2490
Closes #2491
Closes #2492
Closes #2493
Closes #2494
Closes #2495
Closes #2496
Closes #2497

@adamtheturtle
adamtheturtle merged commit f567f15 into main Aug 26, 2026
13 checks passed
@adamtheturtle
adamtheturtle deleted the codex/fix-cli-error-handling branch August 26, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment