Repository navigation
fix(HUB-0000): import ResultExt only where the Windows debug layer probe uses it - #102
Merged
chris-addison merged 1 commit intoNov 14, 2026
Conversation
…obe uses it Release builds never call log_err, so the top-level import was unused and the Hub's warnings-as-errors build failed on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Windows release build, which fails on an unused import since the GPU device-loss change (#98).
directx_devices.rsimportedgpui_util::ResultExtat the top of the file, but its only caller (log_errincheck_debug_layer_available) sits inside#[cfg(debug_assertions)]. Release builds saw an unused import, and the Hub builds with warnings denied, so every Windows release build of the Hub stopped compiling: the nightly signed release (both Windows legs) and the native Hub nightly's Windows jobs.The import now lives inside the debug-only block, next to the other debug-only
use.Related Issues & Discussions
Checklist
AI use: Claude found the failing CI step and wrote the change and this description. Not built for Windows locally (no Windows resource compiler on the Mac); the Hub PR that takes this pin runs the Windows lanes.