Repository navigation
ci(HUB-0000): backport the CI cleanup to unity/hub-4.0 - #101
Merged
Merged
Conversation
Same workflows as unity/hub-consolidated after gpui-ce#100: the `CI Required` rollup, timeouts, concurrency, branch-push caches, just from taiki-e/install-action, setup-rust-toolchain v2 with rustc warnings fatal, and actions/checkout v7. Drops prerelease.yml and release.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chris-addison
marked this pull request as ready for review
November 13, 2026 16:52
Rust 1.100 fails fmt, clippy and two Windows path tests on this branch; consolidated fixed them in its crates (gpui-ce#97). CI-only pin until that is backported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cherry-picked from a30c621 (gpui-ce#97). Rust 1.100 broke fmt (block comment close in the X11 clipboard), clippy (redundant clones in gpui_macros and the parley text system, a duplicated allow) and two Windows path tests (std's verbatim path parsing). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The #97 fixes are backported, so this branch runs current stable again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the CI cleanup from #100 to the
unity/hub-4.0release line, so this branch can require theCI Requiredcheck too.No justfile or
.cargo/config.tomlchanges: everyjustrecipe and test target the jobs call already exists on this branch.Backported fixes from #97
The old CI on this branch last ran on Rust 1.99.1. On current stable (1.100), three checks fail on this branch's code, exactly as they did on
unity/hub-consolidatedbefore #97. The second commit cherry-picks #97 (a30c621) unchanged:crates/gpui_linux/src/linux/x11/clipboard.rs.crates/gpui_macros/src/styles.rs. The same lint also fires on one incrates/gpui_ce_parley/src/text_system.rs, plus a duplicated#[allow(unused)]in the X11 clipboard; clippy stopped at the first crate here, so those didn't show yet.gpui_ce_pathtest_windows_path_style_file_nameandtest_windows_path_style_parent. std's parsing of\\?\verbatim paths changed in 1.100, so those paths now always take the explicit parser.Changes
ci.ymlis ci(HUB-0000): drop unused workflows and harden CI #100's version, with one difference. The Linux headless-render test runs with--features test-support, as it did here, because this branch predates upstream Enable building on Linux with just x11 or wayland, or both. gpui-ce/gpui-ce#379, which made the Linux backends opt-in.audit.ymlis ci(HUB-0000): drop unused workflows and harden CI #100's version.prerelease.ymlandrelease.yml. They publish crates and GitHub releases, which this fork never does.unity/hub-consolidated:CI Requiredrollup job;unity/hub-consolidatedandunity/hub-4.0, and only those pushes save Rust caches;justinstalled withtaiki-e/install-action, sinceextractions/setup-justis blocked by the action allowlist;CARGO_BUILD_WARNINGS: warnandrustflags: -D warningson the compiling jobs, so rustc warnings stay fatal;The reasoning for each change is in #100.
How to test
This PR changes
ci.yml, so every Rust job runs on it.actionlintpasses.Not tested: a docs-only PR (the skip path of
CI Required) and the cache save on a push to this branch.🤖 Generated with Claude Code