Skip to content

Expose Android application storage paths - #120

Merged
Try merged 2 commits into
Try:masterfrom
Solessfir:android-storage
Oct 4, 2026
Merged

Try merged 2 commits into
Try:masterfrom
Solessfir:android-storage

Conversation

@Solessfir

@Solessfir Solessfir commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Adds AndroidApi::internalDataPath() and AndroidApi::externalDataPath() returning std::filesystem::path for native applications. The external path is empty when storage is unavailable. Directory creation and game-specific paths remain application policy. This lets OpenGothic move storage detection into InstallDetect and remove its Java/JNI bridge, as requested in Try/OpenGothic#1001 (comment).

Comment thread Engine/system/api/androidapi.cpp Outdated
static bool active = false;
static bool hasWindow = false;

std::string AndroidApi::internalDataPath() {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be std::filesystem::path

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both accessors now return std::filesystem::path.

Comment thread Engine/system/api/androidapi.cpp
@Try
Try merged commit 800dabb into Try:master Oct 4, 2026
4 checks passed
@Try

Try commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Merged, thanks!

@Solessfir
Solessfir deleted the android-storage branch October 4, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants