Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to Pyrokinesis Issue: #1052
Added spell Pyrokinesis handling for Gothic I
Verification:
Tested Pyrokinesis against NPCs, monsters and Orcs.
Verified damage against targets with different magic protection values.
Checked for regression on other AOE spells such as Gothic I Fire Rain, Ice Wave as well as Gothic II Fire Rain.
Known gap: Pyrokinesis now does not kill, it only strikes NPC down, also after multiple attempts. XP is granted after each strike down, infinitely. I aim to fix this in a separate PR.
Note: Possible additional cleanup case:
Npc::closeWeapon()resets spell-casting state without callingstopSpellTargetEffect(). This can potentially and by chance happen when entering water (falling from an edge, tripping while casting?) and closing the spell wielding weapon state. I could not reproduce this in a normal gameplay but it might be possible by chance. I have therefore left this out of the PR. @Try Let me know if you think it should also be handled incloseWeapon().