Skip to content

Implement Gothic I Pyrokinesis - #1055

Open
Abendlied wants to merge 1 commit into
Try:masterfrom
Abendlied:implement-g1-pyrokinesis
Open

Abendlied wants to merge 1 commit into
Try:masterfrom
Abendlied:implement-g1-pyrokinesis

Conversation

@Abendlied

Copy link
Copy Markdown
Contributor

Refers to Pyrokinesis Issue: #1052

Added spell Pyrokinesis handling for Gothic I

  • Added caster (Player) and target (NPC, monster, Orc) effects for Gothic I Pyrokinesis while casting the spell
  • Trigger damage infliction on the target and stop when casting ends, mana is depleted or casting is interrupted
  • Persistent effects across animation changes
  • Remove persistent effects when the affected target dies
  • Restrict to Gothic I, not interfering with other spells and Gothic II spells

Verification:
Tested Pyrokinesis against NPCs, monsters and Orcs.
Verified damage against targets with different magic protection values.
Checked for regression on other AOE spells such as Gothic I Fire Rain, Ice Wave as well as Gothic II Fire Rain.

Known gap: Pyrokinesis now does not kill, it only strikes NPC down, also after multiple attempts. XP is granted after each strike down, infinitely. I aim to fix this in a separate PR.

Note: Possible additional cleanup case: Npc::closeWeapon() resets spell-casting state without calling stopSpellTargetEffect(). This can potentially and by chance happen when entering water (falling from an edge, tripping while casting?) and closing the spell wielding weapon state. I could not reproduce this in a normal gameplay but it might be possible by chance. I have therefore left this out of the PR. @Try Let me know if you think it should also be handled in closeWeapon().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant