Repository navigation
Fix gliding at the end of jump - #1040
Closed
kroplabeskidu wants to merge 1 commit into
Closed
kroplabeskidu wants to merge 1 commit into
kroplabeskidu wants to merge 1 commit into
Conversation
Root motion of transitions is clamped to the last sample (numFrames-1), not totalTime, so jump doesn't wrap to the start of the arc. Fall speed after takeoff uses current speed instead of average over the whole jump, like vanilla.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jumping downhill the hero kind of floats/glides after the takeoff anim, two things there
T_RUNL_2_JUMP has 21 frames but root motion only has 20 steps, so in the last 40ms translateXZ wrapped around to the start of the arc and the hero got pushed up again mid air. now transitions are clamped to the last root sample and fly transitions keep their last speed till the end
fall speed after takeoff was the average over the whole arc (almost no vertical speed, too fast forward). vanilla starts physics at S_JUMP with velocity from the last few frames, so now it just takes the current speed. comes out ~2.7m/s down instead of ~0.2
with this, fall damage depends more on #1022 (otherwise horizontal speed counts as fall height, in g1 you can die jumping down a small slope)
related #939 #944