Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mod
Npc_ExchangeRoutineis called in zs loop of daily routine and player state is immediately updated but not for non-routines states likeZS_Attack. Basically the same behavior we observed for routine end times. Git blame showedNpc_ExchangeRoutineused to be an immediate routine change but caused trouble withZS_Talk.I made the check for non-routine a function and added some extra checks to have more robustness. Old line is left as last decider.
currentTarget==nullptrseems useful to track other states likeZS_ObservePlayerbut actually don't know what's the difference betweenisTalk()andoutputPipe->isFinished().