Repository navigation
Add configurable sweep-length bounds to LFM and ChirpSS - #494
Open
ahmed100553 wants to merge 1 commit into
Open
ahmed100553 wants to merge 1 commit into
ahmed100553 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #490.
Add optional
samples_per_symbol_minandsamples_per_symbol_maxmetadata to the LFM and ChirpSS generators and pass these bounds through their modulators to the baseband sweep-length selection.1 <= min <= max <= max_num_samples; invalid or incomplete bounds raiseValueError.The output sweep length is the baseband length multiplied by
sample_rate / (4 * bandwidth). The existing defaults and ChirpSS symbol mapping are unchanged.Verification
Local environment: Conda, Python 3.12, NumPy 2.5.4, PyTorch 2.5.1 CPU.
make test: 2753 passed, 9 skipped on this isolated branch.pylint --rcfile=.pylintrc torchsig: exit 0, score 9.74/10.python -m build --no-isolation: source distribution and wheel built successfully.Local verification used Python 3.12; the repository CI provides the Python 3.10 check. No RF hardware or GPU validation is claimed.