unified-poller: log resolved self handle at startup - #61
Conversation
Review caveat from #59 made actionable: on a two-agent machine a shared IAK_SELF_HANDLE makes one poller filter the other's posts. Printing the resolved handle at startup makes the collision visible in the first two log lines instead of days of one agent being mysteriously deaf. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b7fb5eec5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // IAK_SELF_HANDLE at a glance (review caveat on #59): if two pollers on | ||
| // one host print the same handle here, one of them is filtering the | ||
| // other's posts and the wrong agent goes deaf. | ||
| console.log(` self handle: ${resolveSelfHandle({ config: this.config })} (own posts skipped, case-insensitive)`); |
There was a problem hiding this comment.
When running the shipped ide-agent-kit xfor watch or platform watch flows, bin/cli.mjs constructs src/team-relay/unified-poller.mjs, whereas a repo-wide import search shows this edited class is only imported by test/unified-poller.test.mjs. Consequently, this log never executes in the operational two-agent scenario it is intended to diagnose; add it to the team-relay implementation or make the CLI use this implementation.
Useful? React with 👍 / 👎.
1 participant
Makes the #59 review caveat actionable: the resolved self handle prints at poller startup, so a shared IAK_SELF_HANDLE on a two-agent machine is visible immediately instead of surfacing as one agent going deaf.
🤖 Generated with Claude Code