fix(grid-reader): read grid guid - #304
Conversation
ShaMan123
left a comment
ShaMan123
left a comment
There was a problem hiding this comment.
should the guid accessor be guarded?
|
I decided not to guard following the rest of the accessors in the parser |
…obalId GridsController rebuilds GridData with JSON.parse from the data attribute of already-exported .frag files, which carry no guid, so a required field would misdescribe every model exported before #304. web-ifc 0.0.77 also returns a wrapper with value null for an IFCGRID whose GlobalId is unset (probed directly), which would otherwise serialize null into every grid. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Merged, and your call about not guarding was right: we probed web-ifc 0.0.77 directly and an IFCGRID with an unset GlobalId comes back as a wrapper with The problem is what that null does afterwards: it gets serialized into every grid. So we amended with |
2 participants
Description
Read grid guid when parsing ifc