fix(splitter): tests - #253
Conversation
ShaMan123
left a comment
There was a problem hiding this comment.
attributed to claude
|
The test fixes themselves look good. For the fixture, we'd rather go with the build-step alternative you offered than commit the regenerated school_str.frag: that file is shared (it also feeds the Materials example), and pinning sampleIds is exactly the kind of thing #260 predicts will flake. Generating it at test-setup time keeps the tests honest and the repo lighter. What do you think? |
|
I can do it on test setup, no problem. But it seems an overkill for now, since there is a single test that uses it and it is very quick - so I inlined the conversion as part of the test. |
|
Inlining the conversion works great: with it, extract ifc goes green on our machine too, which means the stale committed fixture was the reason that test was failing on main. One thing: the inline conversion pushes the test past vitest's default 5s timeout on our hardware, so it fails by time, not by logic. Could you add an explicit timeout to the heavy tests (60s is plenty)? With that we'll merge right away. |
|
Done |
efba5bc to
a97ffff
Compare
|
Yes: main now has a ci.yml running install, build and the suite on every PR and push. Your timeout fix is what turned it green. |
Description
Resolve the open topics from #197 :
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).