Skip to content

[BUG] Per-host "Allow Session Sharing" toggle shows enabled after being disabled (value is saved correctly) #1356

Closed

Description

@wazam

Title

Host editor shows "Allow Session Sharing" as enabled even though the server stores false

Platform

Website - Firefox

Server Installation Method

Docker

Version

2.8.0

CLI Installation Method

None

CLI Version

No response

Troubleshooting

  • I have examined logs and tried to find the issue
  • I have reviewed opened and closed issues
  • I have tried restarting the application
  • I have checked open issues and ensured this is not a duplicate

The Problem

The per-host "Allow Session Sharing" toggle (Host → SSH → Terminal → Behavior & Advanced) displays as enabled after being disabled, even though the value is saved correctly on the server.

Turning it off shows a "Setting updated" confirmation, and the save request succeeds: the PUT payload and response both contain allowSessionSharing: false, and the following GET /host also returns allowSessionSharing: false for that host. However, reopening the host editor shows the toggle enabled again, including after a hard refresh. Reproduced consistently across multiple attempts.

Because the editor shows the wrong state, saving the host for any other change may write allowSessionSharing: true back, silently re-enabling sharing.

Happens regardless of the instance-wide Admin → General → "Allow Session Sharing" setting (tested with it enabled and disabled).

How to Reproduce

  1. Edit an SSH host → SSH tab → Terminal
  2. Turn off "Allow Session Sharing" ("Setting updated" confirmation appears)
  3. Close and reopen the host editor → toggle shows enabled
  4. In DevTools, GET /host returns allowSessionSharing: false for that host

Additional Context

The backend persists the value correctly; the host editor appears to initialize the toggle from the wrong source or default it to true.

Other per-host toggles on the same host save and display correctly (e.g. enableTerminalToolbar: false).

Possibly related: #1287 (per-host booleans like Command History and Enable Terminal Toolbar reverting to enabled on import) and the "Host command history setting not saving" fix in 2.6.1.

Screenshots of the PUT request payload and response attached.
PUT request payload:
Image
PUT response:
Image

Activity

  1. added theissue type on Sep 28, 2026
  2. termix-triage-bot commented on Sep 28, 2026

    @termix-triage-bot

    Auto-triage

    The 'Allow Session Sharing' toggle in the SSH host editor incorrectly displays as enabled even when its value is saved as false in the backend. This can lead to the setting being unintentionally re-enabled when other host changes are saved.

    Field Value
    Type Bug
    Difficulty 2/5 (Small)
    Priority Urgent
    Labels bug ui ssh platform-web platform-docker good-first-issue

    A maintainer will review shortly. If the auto-classification looks wrong, feel free to say so.

  3. ZacharyZcR commented on Sep 29, 2026

    @ZacharyZcR
    Member

    I confirmed the missing-data path in the editor and opened Termix-SSH/Termix#1499 against dev-2.9.0.

    In 2.8, the sidebar host mapper does not carry allowSessionSharing into the editor. In current dev this setting has moved into the session-sharing plugin, but the same mapper drops pluginSettings entirely, leaving the editor to display the manifest default (true).

    The PR preserves the returned plugin settings map. The regression test follows the real API-host mapper -> editor form -> rendered settings section, with the actual session-sharing manifest, and reproduces false being shown as on before the fix. Both saved boolean values and the other plugin fields survive after it. The related 77 host/editor/settings tests pass.

    This is a fix for the current dev branch; it has not been released in 2.8.0.

  4. termix-triage-bot commented on Oct 1, 2026

    @termix-triage-bot

    This has been fixed and shipped in release-2.9.0-tag. Updating to the latest release will get you this fix. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions