fix: address upstream CI/build issues (#782 #783 #784) - #785
Open
YOMXXX wants to merge 4 commits into
Open
Conversation
7 tasks
Collaborator
|
Thanks for your attention! We will schedule an internal review as soon as possible. |
pr-ci.yml only triggered on PRs to main, but the repo's default/release branch is feat/server_team, so every PR there skipped CI entirely (pack validation, manifest checks, size guard, skill-isolation guard). Trigger on both branches. Fixes TencentCloud#782 Signed-off-by: 李冠辰 <liguanchen@xiaomi.com>
package.json main was "./dist/server.js" and bin/server.mjs / bin/mcp.mjs imported "../dist/server.js", but tsdown (ESM + fixedExtension) emits dist/server.mjs — the .js files do not exist, so npm consumers and the knowledge-server / knowledge-mcp bins failed. Fixes TencentCloud#783 Signed-off-by: 李冠辰 <liguanchen@xiaomi.com>
bodyCache.text is typed string in Hono but holds a Promise at runtime (c.req.text() calls .then()). Cast the cached value to keep runtime behaviour while fixing the TS error. Fixes TencentCloud#784 Signed-off-by: 李冠辰 <liguanchen@xiaomi.com>
The Pack CI job fails on the release branch with "TS5058: scripts/seed-v2/tsconfig.json does not exist" because build:scripts still references the removed seed-v2 directory. Drop the dead script so this branch's CI is green (same change as TencentCloud#775; needed here because TencentCloud#782 now triggers CI on feat/server_team). Part of TencentCloud#759 Signed-off-by: 李冠辰 <liguanchen@xiaomi.com>
YOMXXX
force-pushed
the
fix/782-783-784-upstream-fixes
branch
from
August 5, 2026 10:13
2cf4f9f to
83c6a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #782, #783, #784 — three upstream issues, plus the dead
build:seed-v2that blocks CI on the release branch.#782 — CI never runs on PRs to
feat/server_teampr-ci.ymlonly triggered on PRs tomain, but the default/release branch isfeat/server_team. Trigger on both branches so pack validation, manifest checks, size guard, and skill-isolation guard actually run on PRs.#783 —
main/ bin launchers point atdist/server.js(tsdown emits.mjs)package.jsonmain→./dist/server.mjsbin/server.mjs→import "../dist/server.mjs"bin/mcp.mjs→import "../dist/mcp/server.mjs"npm consumers and
knowledge-server/knowledge-mcpbins now resolve the real build output.#784 —
typecheckfails inresponse-envelope.tsbodyCache.textis typedstringin Hono but holds aPromiseat runtime. Cast the cached value (as unknown as string) to keep runtime behaviour and fix the TS error.(extra) — dead
build:seed-v2breaks CI PackWith CI now enabled (#782), the Pack job surfaced a pre-existing build break:
build:scriptsstill runsbuild:seed-v2, which references the removedscripts/seed-v2/(TS5058). Dropped the dead script so this branch's CI is green (same change as #775, needed here because #782 now triggers CI onfeat/server_team).Verification
MemoryKnowledge:npm run build→ emitsdist/server.mjs;npm run typecheck→ exit 0node --checkon both bin launcherspr-ci.ymlparses withbranches: ["main", "feat/server_team"]MemoryCore:npm run build:scriptspasses (seed-v2 removed)