Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a recorded control has both
aria-labelledbyandaria-label, its target name currently comes fromaria-label. For example, a button witharia-labelledby="action context"referencing “发布” and “服务”, plusaria-label="旧名称", is recorded as “旧名称” even though its accessible name is “发布 服务”. This can make recorded actions harder to match to subsequent observations.Resolve
aria-labelledbytext beforearia-labelin the recording target descriptor. Add regression coverage for buttons, inputs, reference ordering, whitespace normalization, and missing references, and update both changelog translations.Testing
pnpm ext:test --maxWorkers=4: 3,698 passed, 418 skipped.pnpm lint: passed, including DSH typechecking and tests.pnpm --filter @browser-skill/extension compile: passed.pnpm ext:build: passed.uv run --no-project python scripts/check-changelog-sync.py: passed.git diff --check: passed.