Repository navigation
Conversation
tlysanhuo
marked this pull request as ready for review
November 5, 2026 09:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording a contenteditable editor used
textContent, so typingAlpha, Enter,Betaproduced a final Trace v3 fill ofAlphaBeta. PreserveAlpha\nBetaand keep blank/trailing lines without treating a caret placeholder<br>as extra content.Fixes #594.
Extract the existing fill verification reader into a self-contained shared function and use it for recording as well. Native inputs and textareas retain their
.value; simple editable lines retain their existing whitespace/placeholder handling, and rich structures retain rendered-text handling. The fill tool serializes the same function into the page. Includes English and Chinese changelog entries.Validation on Node.js 22.23.4 / Chrome for Testing 157.0.8103.38 (Linux):
pnpm lintpassed. The lint command includes DSH checks: 713 passed, 10 skipped; dependency source-map warnings were non-fatal.git diff --checkpassed.Run the browser regressions with:
BSK_CLICK_CHROME=/path/to/chrome BSK_FILL_CHROME=/path/to/chrome pnpm --filter @browser-skill/extension exec vitest run src/content/__tests__/record-contenteditable.browser.test.ts src/tools/__tests__/fill.browser.test.tsThe recording browser tests bundle the production capture, step buffer and Trace v3 reducer, using native CDP input in an isolated browser/profile. They supply synthetic observation state IDs; they do not cover the installed extension's transport, observation matching, daemon or CLI. Rust tests were not run because no Rust code changed. Browser regressions are opt-in; this PR does not change CI workflows.
Implemented and tested with Codex assistance; no independent human review is claimed.