Skip to content

fix(solid-query-devtools): declare the Web peer and public JSX return type #12160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BleedingDev wants to merge 3 commits into
base: solid-query-v6-pre
Choose a base branch
from
Open

fix(solid-query-devtools): declare the Web peer and public JSX return type #12160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7293a7f
fix(solid-query-devtools): expose the public JSX return type
BleedingDev Oct 19, 2026
5eb100c
ci: apply automated fixes
autofix-ci[bot] Oct 31, 2026
1177146
Merge branch 'solid-query-v6-pre' into fix/solid2-devtools-public-ret…
BleedingDev Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/solid-devtools-public-element.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tanstack/solid-query-devtools": patch
---

Declare the Solid Devtools component return type through the public Web JSX type and require the Web peer used by its published code and declarations.
1 change: 1 addition & 0 deletions packages/solid-query-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"vitest": "^4.0.18"
},
"peerDependencies": {
"@solidjs/web": ">=2.0.0-rc.13 <3.0.0",
"@tanstack/solid-query": "workspace:^",
"solid-js": ">=2.0.0-rc.13 <3.0.0"
}
Expand Down
5 changes: 4 additions & 1 deletion packages/solid-query-devtools/src/devtools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import type {
Theme,
} from '@tanstack/query-devtools'
import type { QueryClient } from '@tanstack/solid-query'
import type { JSX } from '@solidjs/web'

interface DevtoolsOptions {
/**
Expand Down Expand Up @@ -53,7 +54,9 @@ interface DevtoolsOptions {
theme?: Theme
}

export default function SolidQueryDevtools(props: DevtoolsOptions) {
export default function SolidQueryDevtools(
props: DevtoolsOptions,
): JSX.Element {
const queryClient = useQueryClient(props.client)
const client = createMemo(() => queryClient)
let ref!: HTMLDivElement
Expand Down