Skip to content

Update New Ticket button styling - #1354

Merged
fnets merged 8 commits into
mainfrom
task/wp-1320-new-ticket
Oct 8, 2026
Merged

fnets merged 8 commits into
mainfrom
task/wp-1320-new-ticket

Conversation

@jmartinez-tacc

Copy link
Copy Markdown
Contributor

Overview

Update New Ticket button styling to be consistent with the other buttons style

Related

Changes

  • Mimic the New Ticket style to match the secondary style

Testing

  1. Go to Dashboard
  2. New Ticket button styling should be consistent with the rest of the secondary buttons

UI

Screenshot 2026-09-01 at 11 41 50 AM Screenshot 2026-09-01 at 11 42 00 AM

Notes

@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.11%. Comparing base (4ce8ea8) to head (6b6f259).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
+ Coverage   57.07%   57.11%   +0.03%     
==========================================
  Files         541      542       +1     
  Lines       17332    17346      +14     
  Branches     3673     3678       +5     
==========================================
+ Hits         9893     9907      +14     
  Misses       6893     6893              
  Partials      546      546              
Flag Coverage Δ
javascript 59.82% <100.00%> (+0.06%) ⬆️
unittests 54.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/src/components/Dashboard/Dashboard.jsx 63.04% <ø> (ø)
client/src/components/_common/Link/Link.jsx 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fnets fnets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good use of the CSS variables

Comment thread client/src/components/Dashboard/Dashboard.jsx Outdated

@fnets fnets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could resolve these conflicts, I think this would lgtm

Comment thread client/src/components/Dashboard/Dashboard.jsx
@rstijerina

Copy link
Copy Markdown
Member

@jmartinez-tacc You just need to resolve the conflicts here

@fnets fnets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all your hard work on this

@fnets
fnets merged commit e11832f into main Oct 8, 2026
6 checks passed
@fnets
fnets deleted the task/wp-1320-new-ticket branch October 8, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants