-
Notifications
You must be signed in to change notification settings - Fork 2
feat: CMD-187 autocreate search page #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
wesleyboar
wants to merge
74
commits into
release/v4.36.X
from
feat/template-and-setting-for-google-search
Closed
Changes from all commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
4515b85
feat: template & setting for Google search
wesleyboar 2883e49
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 8607c90
fix: styles and fallback warning for Google Search
wesleyboar f3dc4dc
enhance: move sarch CSS to its own file
wesleyboar 3947bc2
enhance: rename search stylesheet and ID
wesleyboar d0d5e00
refactor: move css to top of template
wesleyboar b74e2a0
fix: missing default GOOGLE_SEARCH_ENGINE_ID
wesleyboar 7c93b7e
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar f80ebc8
feat: search template is standard
wesleyboar 5208bde
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 9457519
feat: convert search template into a search app
wesleyboar 16d34c3
feat(search_page): slimmer views.py
wesleyboar da3a73a
feat(search): create page if it does not exist
wesleyboar 5fb5a32
fix(search): restore breadcrumbs
wesleyboar 1fef4f8
chore(search_page): remove now-unnecessary file
wesleyboar e8072e6
enhance(search_page): flag page as auto-generated
wesleyboar 3291015
enhance(search): attach apphook to manage urls
wesleyboar ca11f07
style(search): polish
wesleyboar 445010c
fix(search): searchbar not using curr. search path
wesleyboar 8d812c8
chore(search): remove cruft
wesleyboar 3793bb9
chore(search): reduce silly complexity of tag
wesleyboar 92e9ecf
chore(search): remove cruft 2
wesleyboar adf6ad2
feat(search): auto isntall and setup
wesleyboar d9db279
feat(search): simplify an isolate markup
wesleyboar fda65e5
core(search): remove cruft markup
wesleyboar 9d88be6
chore(search): simlify utils.py
wesleyboar 148f661
style(search): new line
wesleyboar 7cbb96e
refactor(search): polish
wesleyboar f57d4e1
refactor(search): rename a function
wesleyboar 55b84da
style(search): ending slash for example path
wesleyboar 3ee4fe1
style(search): ending slash for example path
wesleyboar b4d6ac3
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 0f16d38
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar ba2b091
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 959ba8e
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 7dd0402
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar a12a70f
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 74230c0
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 34be454
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar a1a79b5
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 448b6b3
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 1db6303
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 6de0143
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 645b8b7
fix: search results style bugs
wesleyboar 18695ab
fix: MORE search results style bugs
wesleyboar 846e35e
fix(a11y): lighter accent color
wesleyboar 3263ccf
Quick: Rename csrftoken to csrfcookie (#1122)
jarosenb 6eafc75
feat: initial bootstrap 5 support (#1123)
wesleyboar b836015
fix: a11y issues (#1089)
wesleyboar 67fed8b
Merge branch 'release/v4.36.X' into feat/template-and-setting-for-goo…
wesleyboar 51c9098
fix: news read-more link can't click (#1131)
wesleyboar 0cca2af
chore: add "accessibility" to labels conf
wesleyboar 6e7f4bc
refactor: figure & blockquote, @mixin not @extend (#1135)
wesleyboar a3b3cda
deps: core-styles for more a11y fixes (#1140)
wesleyboar fc1c500
fix: a11y issues, round 2 (#1141)
wesleyboar 57b6523
ci: add .gitmessage
wesleyboar 6bc76ec
style: new line for immediate typing .gitmessage
wesleyboar 5cd2d20
docs: explain PR template better (rename to uppercase)
wesleyboar 588aa02
docs: PR template testing instructions for CMS
wesleyboar ff41687
docs: PR template tweaks
wesleyboar 208611d
chore(deps): core-styles v2.55 + section--accent (#1144)
wesleyboar 5cb2b4e
chore(ci): bump node to 20 to match core-styles (#1145)
wesleyboar 76f1d09
chore: bump node to 20 in package.json
wesleyboar a5905e2
chore(deps): bump core-styles again for a11y (#1146)
wesleyboar 28bb1a7
fix: footer links (#1147)
wesleyboar deeb8c7
fix(ai): target="_blank" rel="noopener noreferrer"
wesleyboar bc6f9b4
docs: fix default URL path for style QA page
wesleyboar 0446f9b
docs: fix inaccurate section style manage cmd details (#1148)
wesleyboar 8122b86
docs(AGENTS): pull requests
wesleyboar 27e8d8d
docs(AGENTS): formatting clean up
wesleyboar b53ded6
docs(AGENTS): clarity
wesleyboar 87f95c1
chore(deps): use Core-Styles footer fix branch (#1149)
wesleyboar 4f14e0e
Merge branch 'main' into feat/template-and-setting-for-google-search
wesleyboar 5d0b3e2
Merge branch 'release/v4.36.X' into feat/template-and-setting-for-goo…
wesleyboar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| ## Overview | ||
|
|
||
| <!-- | ||
| 1–3 sentences stating what problem this solves and what you changed at a high level. Example: | ||
|
|
||
| "Fixes caption contrast on dark sections by using opacity instead of a fixed dark color." | ||
| --> | ||
|
|
||
| … | ||
|
|
||
| ## Related | ||
|
|
||
| <!-- | ||
| Delete the bullets you don't need. Any ticket / cross-repo links go here. Examples: | ||
|
|
||
| - [CMD-XYZ](https://tacc-main.atlassian.net/browse/CMD-XYZ) | ||
| - requires https://github.com/TACC/Some-Repo/pull/NNN | ||
| - required by https://github.com/TACC/Other-Repo/pull/NNN | ||
| --> | ||
|
|
||
| - … | ||
|
|
||
| ## Changes | ||
|
|
||
| <!-- | ||
| Use short bullets. Add bold verb as prefix to help scanning; example: | ||
|
|
||
| - **added** `.o-widget--compact` modifier | ||
| - **updated** demo markup for Fractality | ||
| - **deleted** cruft in a working file | ||
| - **fixed** typo | ||
| --> | ||
|
|
||
| - … | ||
|
|
||
| ## Testing | ||
|
|
||
| <!-- | ||
| Numbered steps another dev can repeat. Include local URLs for UI changes. Example: | ||
|
|
||
| 1. `make start` | ||
| 2. Create a page with plugin X that has setting Y with value Z. | ||
| 3. Verify UI shows … | ||
| --> | ||
|
|
||
| 1. | ||
|
|
||
|
|
||
| ## UI | ||
|
|
||
| <!-- | ||
| Add screenshots via GitHub PR editor. Organize and label with a table; example: | ||
|
|
||
| | Before | After | | ||
| | - | - | | ||
| | <img width="900" alt="before" src="..." /> | <img width="900" alt="after" src="..." /> | | ||
| --> | ||
|
|
||
| … | ||
|
|
||
| <!-- | ||
| ## Notes | ||
|
|
||
| Optional: rollout, follow-ups, known limitations, unrelated dist churn. | ||
| --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
|
|
||
|
|
||
| # type(scope)!: short summary | ||
| # | ||
| # Types: feat, fix, docs, style, refactor, perf, test, chore, build, ci | ||
| # Scope (optional): describes area, e.g. api, ui, auth, deps | ||
| # ! (optional): marks breaking changes | ||
| # | ||
| # Examples: | ||
| # feat(api)!: add user search endpoint | ||
| # chore(deps): update | ||
| # style: delete excess whitespace | ||
| # | ||
| # Body (optional): | ||
| # What changed and why | ||
| # Important design decisions or context | ||
| # | ||
| # Footer (optional): | ||
| # BREAKING CHANGE: describe breaking change | ||
| # Closes #123, Relates-to #456 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| [pr_reviewer] | ||
| extra_instructions = """ | ||
| Do not flag missing `rel="noopener noreferrer"` on `target="_blank"` links as a security issue. Modern browsers implicitly apply `noopener` per the HTML spec. This is not an active vulnerability. | ||
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| from django.apps import AppConfig | ||
| from django.conf import settings | ||
|
|
||
| class SearchPageConfig(AppConfig): | ||
| name = 'apps.search_page' | ||
|
|
||
| def ready(self): | ||
| if settings.SEARCH_PAGE_AUTO_SETUP: | ||
| from .utils import create_page | ||
| create_page() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| from cms.app_base import CMSApp | ||
| from cms.apphook_pool import apphook_pool | ||
|
|
||
|
|
||
| @apphook_pool.register | ||
| class SearchPageApphook(CMSApp): | ||
| app_name = 'apps.search_page' | ||
| name = 'SearchPage' | ||
|
|
||
| def get_urls(self, page=None, language=None, **kwargs): | ||
| return ['apps.search_page.urls'] |
152 changes: 152 additions & 0 deletions
152
apps/search_page/static/search_page/css/google-search.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| #google-search { | ||
|
|
||
| &:is(#cms-content-container > *:last-child) { | ||
| margin-bottom: var(--global-space--section-gap, 60px); | ||
| } | ||
|
|
||
| /* SEARCH CONTAINER */ | ||
|
|
||
| /* To remove padding from search container */ | ||
| & .gsc-control-cse { | ||
| padding: unset; | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /* TABLE OF SEARCH STATS & SORTING OPTIONS */ | ||
|
|
||
| /* To remove border from search analytics, add gray background */ | ||
| & .gsc-above-wrapper-area { | ||
| --bkgd-color: var(--global-color-primary--x-light); | ||
|
|
||
| background-color: var(--bkgd-color); | ||
| box-shadow: 40vw 0 var(--bkgd-color), -40vw 0 var(--bkgd-color); | ||
| border-bottom: unset; | ||
| } | ||
|
|
||
| & .gsc-above-wrapper-area-container { | ||
| border-bottom: unset; | ||
| } | ||
|
|
||
| /* To override Core-Styles tables */ | ||
| & tbody > tr:first-child > :is(td, th) { | ||
| border: unset; | ||
| padding-inline: unset; | ||
| background: unset; | ||
| vertical-align: middle; | ||
| } | ||
|
|
||
| & .gsc-selected-option-container { | ||
| background: var(--global-color-primary--xx-light); | ||
| border: var(--global-border--normal); | ||
| } | ||
|
|
||
| & .gsc-result-info { | ||
| padding: unset; | ||
| font-size: var(--global-font-size--medium); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /* SUGGESTION PHRASE (after "Did you mean:") */ | ||
|
|
||
| & .gs-spelling { | ||
| padding: unset; | ||
| } | ||
| & .gs-spelling a { | ||
| color: var(--global-color-accent--light); | ||
|
|
||
| /* to undo core-styles.base */ | ||
| /* https://github.com/TACC/Core-Styles/blob/8ab89d3/src/lib/_imports/elements/links.css */ | ||
| &:not([href]) { | ||
| opacity: 1; | ||
| pointer-events: auto; | ||
| } | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /* SEARCH RESULTS */ | ||
|
|
||
| /* (search result body text) */ | ||
| & .gs-snippet { | ||
| color: var(--global-color-primary--dark); | ||
| } | ||
|
|
||
| /* (url under search result title) */ | ||
| & .gs-webResult div.gs-visibleUrl { | ||
| color: var(--global-color-secondary--normal); | ||
| } | ||
|
|
||
| /* (search result titles) */ | ||
| & a.gs-title:link { | ||
| color: var(--global-color-accent--light); | ||
| text-decoration: none; | ||
| text-decoration-thickness: var(--global-border-width--normal); | ||
| text-underline-offset: 0.2em; | ||
| } | ||
| & a.gs-title:link:hover { | ||
| text-decoration-line: underline; | ||
| text-decoration-style: solid; | ||
| } | ||
| & a.gs-title b { | ||
| color: currentColor; | ||
| } | ||
| & .gs-result .gs-title:not(a):hover { | ||
| /* to remove duplicate underline */ | ||
| /* (fix Google's default_v6+en.css bug `.gs-result .gs-title:hover`) */ | ||
| text-decoration: auto; | ||
| } | ||
|
|
||
| /* (push search-result description to right) */ | ||
| & .gs-image-box { | ||
| margin-right: 10px; | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /* GOOGLE PAGE NAVIGATION (at bottom) */ | ||
|
|
||
| & .gsc-cursor-box { | ||
| display: flex; | ||
| justify-content: center; | ||
| margin-block: var(--global-space--large); | ||
| } | ||
|
|
||
| & .gsc-cursor-current-page { | ||
| color: var(--global-color-accent--light); | ||
| text-decoration: none; | ||
| text-decoration-thickness: var(--global-border-width--normal); | ||
| text-underline-offset: 0.2em; | ||
| } | ||
|
|
||
| & .gsc-cursor-current-page:hover { | ||
| text-decoration-line: underline; | ||
| text-decoration-style: solid; | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /* GOOGLE BRANDING */ | ||
|
|
||
| & .gcsc-find-more-on-google { | ||
| color: var(--global-color-accent--light); | ||
| text-decoration: none; | ||
| text-decoration-thickness: var(--global-border-width--normal); | ||
| text-underline-offset: 0.2em; | ||
| } | ||
| svg.gcsc-find-more-on-google-magnifier { | ||
| fill: currentColor; | ||
| } | ||
|
|
||
| & .gcsc-find-more-on-google:hover { | ||
| text-decoration-line: underline; | ||
| text-decoration-style: solid; | ||
| } | ||
|
|
||
| & .gcsc-branding-img-noclear { | ||
| vertical-align: unset; | ||
| top: 1px; | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Db write in appconfig.ready
🐞 Bug☼ ReliabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools