Conversation
They only existed on the test-build/fixes-plus-features branch, which is 362 commits behind upstream, so they were one branch deletion away from being lost and drifted from mainstream. main already carried the Linux one, so all three now live together and build against current upstream. Also drop three em dashes from the macOS release notes.
After a search selects a match, the found line is already the selected row, so re-tapping it raises no SelectionChanged and the matched text stays selected. Line level actions such as italic then apply only to the selected fragment. Collapse the edit box selection on any grid tap so selecting the line acts on the whole line. Fixes SubtitleEdit#12688.
|
@niksedk this fixes #12688. After a search the found row is already selected, so re-tapping it raises no SelectionChanged and the matched text stays selected, which made Ctrl+I italic apply to just the found fragment instead of the whole line (a regression from SE4). The change collapses the edit box selection on any grid tap, so tapping the line acts on the whole line again, while Ctrl+I right after a search still italicizes only the found word. The reporter tested a build and confirmed it works as expected. Ready for review when you have a chance. |
|
Hi @muaz978, thanks for digging into this one and for getting the reporter to verify a test build - much appreciated. I'm closing this while tidying up the open PR list before the 5.2 release. The linked issue (#12688) has been closed by the reporter, and the PR also carries changes to the test-build workflows that I'd rather keep separate from a grid/edit-box fix. If the "selection survives a re-tap after search" behaviour comes up again, I'll do a small targeted change for it in Thanks again! |
|
Thanks Nikolaj, that all makes sense. Agreed the workflow diff didn't belong in a grid/edit-box fix. I'll leave the targeted MainViewModel fix to you, happy to help track it down again if it resurfaces. |
2 participants
Fixes #12688.
When a search finds a match, Find selects the found line in the grid and also selects the matched text inside the edit box. Selecting a different line clears that edit box selection in
SubtitleGridSelectionChanged, but that only runs on an actual selection change. After a search the found row is already the selected row, so re-tapping it raises noSelectionChangedand the matched text stays selected. Line level actions such as italic (Ctrl+I) then apply only to the selected fragment instead of the whole line, which is not what the user expects and differs from Subtitle Edit 4.This collapses the edit box selection on any grid tap in
OnSubtitleGridSingleTapped, so tapping a row always acts as selecting that line and line level actions apply to the whole line. Pressing Ctrl+I right after a search without clicking the row still italicizes just the found word, so both behaviors remain available.A portable Windows x64 test build is attached to the issue for verification.