Matter Switch: Update table removal method, update table emptiness checks - #3223
Open
hcarter-775 wants to merge 1 commit into
Open
Matter Switch: Update table removal method, update table emptiness checks#3223hcarter-775 wants to merge 1 commit into
hcarter-775 wants to merge 1 commit into
Conversation
|
Invitation URL: |
|
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 82a207b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Update method for removing table indices from a field, from just setting the table indices to nil (which leaves holes in tables) to actually dropping them from the table altogether. Also, update the table emptiness check to check whether next() is nil, to avoid any future issues with the '#' operator, which is invalid if keys are not ordered. Also, add and update some logging to be more useful via hub log methods.
Summary of Completed Tests
Tests added to check this works as expected, specifically for devices reporting endpoints out of order.