Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, I wrote these integration tests to verify #15 (the updated
simple_secure_storage_linuximplementation), since they can run directly using Dart without an example app or a Flutter engine, as the updated implementation does not depend on Flutter method channels.However, that skips the platform implementation registration path, and the tests are verifying the public behavior of
SimpleSecureStorageso they can be reused on other platforms as well. So I kept them insimple_secure_storage/example/integration_test.I ran the tests on CachyOS (KDE Plasma, KWallet) using:
flutter test integration_test/secure_storage_test.dart -d linux(insidesimple_secure_storage/example).These tests do not test everything or platform-specific edge cases; however,
freedesktop_secretalready has integration tests.Note: These tests share similarities with some of the packages in this repository.