Skip to content

Make E2E authentication setup resilient - #8326

Merged
isaacroldan merged 6 commits into
mainfrom
isaac/e2e-auth-resilience
Aug 14, 2026
Merged

Make E2E authentication setup resilient#8326
isaacroldan merged 6 commits into
mainfrom
isaac/e2e-auth-resilience

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Why

Remote E2E authentication failures do not identify the failed stage, and transient device-login or page-load failures require a complete rerun.

Stacked on #8325.

What

  • Validate required remote E2E configuration when global authentication starts.
  • Classify authentication failures as configuration, PTY startup, device-code generation, browser login, or session prewarm.
  • Retry only transient device-code, login page-load, CLI confirmation, and prewarm page-load failures once.
  • Remove the per-worker fallback login so all remote workers use the diagnosed authentication setup.
  • Emit safe stage and reason diagnostics without raw CLI output, login URLs, credentials, cookies, or load-test header values.
  • Wait for delayed client-side redirects before validating authenticated prewarm destinations.
  • Add local Playwright coverage for validation, retry selection, retry boundaries, HTTP failures, destination waits, and diagnostic redaction.

Testing

  • pnpm --filter @shopify/e2e lint
  • pnpm --filter @shopify/e2e type-check
  • pnpm exec playwright test tests/auth-diagnostics.spec.ts --project local (9 passed)
  • Workflow YAML parsing and git diff --check passed
  • Both remote shard test lists include the authentication setup

Assisted-By: devx/215513a9-13fa-4e74-bb8f-79faee6e4f09
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 13, 2026
Assisted-By: devx/215513a9-13fa-4e74-bb8f-79faee6e4f09
Assisted-By: devx/215513a9-13fa-4e74-bb8f-79faee6e4f09
Assisted-By: devx/215513a9-13fa-4e74-bb8f-79faee6e4f09
@isaacroldan
isaacroldan force-pushed the isaac/e2e-auth-resilience branch from 4357657 to 6cab447 Compare August 13, 2026 15:13
Assisted-By: devx/215513a9-13fa-4e74-bb8f-79faee6e4f09
Assisted-By: devx/215513a9-13fa-4e74-bb8f-79faee6e4f09
@isaacroldan
isaacroldan marked this pull request as ready for review August 13, 2026 15:30
@isaacroldan
isaacroldan requested a review from a team as a code owner August 13, 2026 15:30
Base automatically changed from isaac/split-local-remote-e2e to main August 14, 2026 08:59
@isaacroldan
isaacroldan added this pull request to the merge queue Aug 14, 2026
Merged via the queue into main with commit 303fe9b Aug 14, 2026
28 checks passed
@isaacroldan
isaacroldan deleted the isaac/e2e-auth-resilience branch August 14, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants