Repository navigation
Apply current Runic formatting - #171
Merged
ChrisRackauckas merged 1 commit intoSep 7, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Apply Runic 1.10's canonical formatting to the files that currently fail the repository-wide format check. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: OpenAI Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.151.0 Agent-Model: gpt-5.6-sol Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
ChrisRackauckas-Claude
force-pushed
the
codex/runic-format-current
branch
from
September 4, 2026 07:21
4082c0c to
7b119f5
Compare
Member
Author
|
Final hosted validation is green.
Workflow run: https://github.com/SciML/HighDimPDE.jl/actions/runs/33848388669 |
ChrisRackauckas
marked this pull request as ready for review
September 7, 2026 06:10
ChrisRackauckas
added a commit
that referenced
this pull request
Sep 7, 2026
- compat: drop the unregistered SafeTestsets 1.x major (#168) - test: use Float32 noise in GPU reflect equivalence test (#169) - Fix docs compatibility with HighDimPDE 2 (#170) - Apply current Runic formatting (#171) Agent-Harness: Claude Code Agent-Model: claude-opus-5[1m] Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Apply Runic 1.10's canonical formatting to the three files that currently fail the repository-wide format check. This is a mechanical-only change: it normalizes comprehension indentation and the
Float32literal spelling, with no behavior or documentation changes.Please ignore this PR until it has been reviewed by @ChrisRackauckas.
Root cause
The hosted Runic failure reproduces locally on a clean current-main checkout. With the CI version, Runic 1.9.0,
git bisectpasses ata7b882b466d17c20bcb31cf5367a317bb63430e6and identifies44fbfc9192d77aad76ee92103a02bd5704647a62(#169) as the first failing commit; that commit introduced the non-canonical2f0spelling. Current Runic 1.10 additionally canonicalizes two older comprehension layouts, so this PR formats all three files reported by the repository's unpinned major-1 formatter check.Failing before
On clean current main with Runic 1.9.0:
With current Runic 1.10.0, the same clean-main check also reports layout changes in
src/MLP.jlandtest/shared/DeepBSDE_Han.jl.Passing after
NNKolmogorovalso ran in the Core group, and the complete group exited successfully; its summary was not retained in the captured terminal tail.Not verified here
Links
🤖 Generated with Codex CLI 0.151.0 (model: gpt-5.6-sol; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d).