Skip to content

Apply current Runic formatting - #171

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/runic-format-current
Sep 7, 2026
Merged

ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/runic-format-current

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Sep 4, 2026 •

Copy link
Copy Markdown
Member

What changed and why

Apply Runic 1.10's canonical formatting to the three files that currently fail the repository-wide format check. This is a mechanical-only change: it normalizes comprehension indentation and the Float32 literal spelling, with no behavior or documentation changes.

Please ignore this PR until it has been reviewed by @ChrisRackauckas.

Root cause

The hosted Runic failure reproduces locally on a clean current-main checkout. With the CI version, Runic 1.9.0, git bisect passes at a7b882b466d17c20bcb31cf5367a317bb63430e6 and identifies 44fbfc9192d77aad76ee92103a02bd5704647a62 (#169) as the first failing commit; that commit introduced the non-canonical 2f0 spelling. Current Runic 1.10 additionally canonicalizes two older comprehension layouts, so this PR formats all three files reported by the repository's unpinned major-1 formatter check.

Failing before

On clean current main with Runic 1.9.0:

$ julia +release --project=../.tmp/runic19-env -m Runic --check --diff .
diff --git a/test/reflect.jl b/test/reflect.jl
@@
-            b = a + 2f0 .* randn(Float32, size(a))
+            b = a + 2.0f0 .* randn(Float32, size(a))
# exit 1

With current Runic 1.10.0, the same clean-main check also reports layout changes in src/MLP.jl and test/shared/DeepBSDE_Han.jl.

Passing after

$ julia +release --project=../.tmp/runic-env -m Runic --check --diff .
# exit 0; no output

$ GROUP=QA julia +release --project -e 'using Pkg; Pkg.test()'
Test Summary: | Pass  Total     Time
QA            |   20     20  2m44.9s
     Testing HighDimPDE tests passed

$ GROUP=Core julia +release --project -e 'using Pkg; Pkg.test()'
Test Summary:       | Pass  Total
ProblemConstructors |  154    154
reflect             |    2      2
MLP                 |   23     23
Deep Splitting      |   19     19
DeepBSDE            |    6      6
MC Sample           |    7      7
NNStopping          |    2      2
NNParamKolmogorov   |    1      1
     Testing HighDimPDE tests passed

$ typos src/MLP.jl test/reflect.jl test/shared/DeepBSDE_Han.jl
# exit 0; no output

$ git diff --check HEAD^
# exit 0; no output

NNKolmogorov also ran in the Core group, and the complete group exited successfully; its summary was not retained in the captured terminal tail.

Not verified here

  • The GPU path was not run because a functional CUDA device is unavailable. The changed GPU-gated line is formatting-only.
  • Docs were not rebuilt on this formatter-only branch because current main has a separately bisected docs self-compatibility failure. Draft PR Fix docs compatibility with HighDimPDE 2 #170 fixes that one-line docs compatibility issue and passes the strict docs build.
  • Julia pre-release and downstream jobs were not run locally.

Links

🤖 Generated with Codex CLI 0.151.0 (model: gpt-5.6-sol; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d).

Apply Runic 1.10's canonical formatting to the files that currently fail the repository-wide format check.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Agent-Harness: Codex CLI 0.151.0
Agent-Model: gpt-5.6-sol
Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

Final hosted validation is green.

  • 17 required checks passed.
  • The matrix includes Core on Julia 1/LTS/pre across Ubuntu, macOS, and Windows; QA; the LTS GPU group; the standalone GPU test; downgrade; Runic; Runic suggestions; spelling; and test detection.
  • The documentation job was skipped as expected for this formatting-only change.
  • After git fetch upstream, git rev-list --count HEAD..upstream/main returned 0; the branch is current with upstream main.

Workflow run: https://github.com/SciML/HighDimPDE.jl/actions/runs/33848388669

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review September 7, 2026 06:10
@ChrisRackauckas
ChrisRackauckas merged commit a29cefe into SciML:main Sep 7, 2026
18 checks passed
ChrisRackauckas added a commit that referenced this pull request Sep 7, 2026
- compat: drop the unregistered SafeTestsets 1.x major (#168)
- test: use Float32 noise in GPU reflect equivalence test (#169)
- Fix docs compatibility with HighDimPDE 2 (#170)
- Apply current Runic formatting (#171)



Agent-Harness: Claude Code
Agent-Model: claude-opus-5[1m]
Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants