Skip to content

Adding hyperon filter for Gen2 production - #956

Merged
aantonakis merged 1 commit into
production/sbnd-gen2from
feature/hyperon-gen2-filter
Sep 2, 2026
Merged

Adding hyperon filter for Gen2 production#956
aantonakis merged 1 commit into
production/sbnd-gen2from
feature/hyperon-gen2-filter

Conversation

@tjones79

@tjones79 tjones79 commented Aug 13, 2026

Copy link
Copy Markdown

Description

Please provide a detailed description of the changes this pull request introduces.

Adds the sbnd_hyperon_filter block to signal_filters_sbnd.fcl and wires it up in run_sbnd_gen2_rare_signal_filter.fcl to enable Gen2 exclusive hyperon filtering.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{blue}\bf{\textrm{IMPORTANT UPDATE Feb 2nd 2026:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production for gen 2 SBND analyses, you must make two PRs: one for develop and one for the production/sbnd-gen2 branch.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
No

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
N/A

Assigning as draft as I am still extracting neccesary filter info

I have confirmed that after the running the filter on a generated sample of beam + corsika + rockbox, that there are events in my output file. Below are the relevant metrics. I have also attached a file that shows the end of the art log file wth the summaries. -> filter_end_log.txt

Filter Performance Metrics (Based on 11,794 generated events):

  • Filter Efficiency: 14 / 11,794 events (~0.12% retention for the hyperon stream)
  • Average CPU Time (hyperon filter module): ~0.026 seconds / event
  • Output File Size: 525 MB total (~37.5 MB / saved event)

@tjones79 tjones79 self-assigned this Aug 13, 2026
@tjones79 tjones79 added the simulation genie or geant4 (g4) label Aug 13, 2026
@tjones79
tjones79 marked this pull request as ready for review August 13, 2026 14:35
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Gen2 Production Aug 19, 2026

@linyan-w linyan-w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pending other reviewers.
@tjones79 could you confirm you see your desired events in your test?
@tbwester could you please review?

@tjones79

Copy link
Copy Markdown
Author

Hi @linyan-w

I can confirm that the 14 events filtered were indeed events that contain hyperons, as desired :)

@aantonakis

Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_14_02_06 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_03 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_06

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@aantonakis

Copy link
Copy Markdown
Contributor

Hi @linyan-w and @tjones79, I'm happy to merge this PR unless we want to wait for Thomas Wester to review it as well?

@linyan-w

linyan-w commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Hi @linyan-w and @tjones79, I'm happy to merge this PR unless we want to wait for Thomas Wester to review it as well?

No you're the release MASTER! As long as you're happy

@aantonakis
aantonakis merged commit 69ecb36 into production/sbnd-gen2 Sep 2, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

simulation genie or geant4 (g4)

Projects

Status: Waiting on Reviewer

Development

Successfully merging this pull request may close these issues.

4 participants