Fix regression: Allow FIFO / process substitution for --read-batch - #1060
Open
seks99x wants to merge 2 commits into
Open
Fix regression: Allow FIFO / process substitution for --read-batch#1060seks99x wants to merge 2 commits into
seks99x wants to merge 2 commits into
Conversation
Updated batch file checks to allow FIFO pipes while rejecting non-regular files.
seks99x
force-pushed
the
seks99x-batch-fix
branch
4 times, most recently
from
August 15, 2026 17:00
a1250e1 to
9ec4992
Compare
seks99x
force-pushed
the
seks99x-batch-fix
branch
from
August 15, 2026 17:19
9ec4992 to
0580585
Compare
Member
Author
|
the PR wont pass the CI without merging PR #1054 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V3.5.0 in batch.c commit 1604890 introduced a strict S_ISREG check for --read-batch argument paths. This inadvertently breaks bash process substitution (e.g., <(...)), which passes file descriptors as FIFOs (S_IFIFO).
Testing against the 3.4 branch succeeds, but fails on the current 3.5.0dev branch:
Bash
The Fix:
Modified the check in batch.c open_batch_file() to permit S_ISFIFO alongside S_ISREG.