Repository navigation
Dev to main merge - #1182
Merged
Merged
Dev to main merge#1182
Conversation
* fix: status card for changes requested and application redirection * test: fix breaking test for application detail
* fix: status card for changes requested and application redirection * test: fix breaking test for application detail * test: new join step one, two, three
* chore: migrate to pnpm 11 with devEngines-managed node runtime pnpm 11 stopped reading settings from .npmrc, which silently dropped the hoisting config the Ember build relies on, and its strict build-script policy fails installs until dependencies are reviewed. Move settings to pnpm-workspace.yaml with an explicit allowBuilds policy, and replace the advisory volta pin with devEngines (onFail: download) so pnpm itself provisions the exact node and pnpm versions from the lockfile. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: let pnpm provision node via devEngines, pin pnpm major, cache store setup-node and the node matrix are redundant now that pnpm downloads the lockfile-pinned runtime itself. Pin pnpm/action-setup to major 11 instead of "latest" (which is what broke CI when pnpm 11 shipped); the precise version stays governed by devEngines. Also add pnpm store caching and bump checkout off deprecated v2/v3. Co-authored-by: Cursor <cursoragent@cursor.com> * chore: drop only-allow preinstall guard devEngines.packageManager now pins pnpm itself, and the committed pnpm-lock.yaml makes npm/yarn installs fail naturally, so the guard is redundant. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: pin action refs to commit SHAs Tags are mutable, so a compromised action repository could repoint them at malicious code. Pinning to full commit SHAs (with the tag noted in a comment) keeps the executed workflow code fixed. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: document refreshing pinned action SHAs SHA pins do not update themselves, so record why they exist and the procedure for bumping them in README, with a pointer from the workflow. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: bootstrap pnpm standalone and restore engineStrict (review feedback) pnpm 11 needs Node >= 22.13 just to start (node:sqlite), so an npm/Corepack-installed pnpm on an older Node crashes before devEngines.runtime can download the pinned Node. Install pnpm standalone in CI (@pnpm/exe bundles its own Node) and document the standalone install script for contributors. Also carry engine-strict=true from the deleted .npmrc into pnpm-workspace.yaml as engineStrict. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: keep eslint out of local agent worktrees under .claude/ The '!**/.*' ignore negation (needed to lint dotfiles like .prettierrc.js) also un-ignored .claude/, so eslint walked the agent worktree checkouts and failed no-undef on their copies of root-relative CJS files. Re-ignore .claude/ after the negation, since the last matching pattern wins. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
…replace company with college (#1159) * refactor: new join steps and social steps to use profile username * fix: naming and bg color for social pill * refactor: new step four to use config * fix: safely normalize social profile usernames
* refactor: new join steps and social steps to use profile username * fix: naming and bg color for social pill * refactor: new step four to use config * fix: safely normalize social profile usernames * test: add tests for new join steps 4 and 5 * test: add test for new join step four * fix: assertion for step six for empty values * test: cover social username normalization
devEngines pinned pnpm to the 11.x major, so anyone whose installed pnpm is 12 (the current latest) paid a provisioning hop on every command: pnpm resolved the pin, downloaded pnpm 11 into its version store, and re-executed through it. That measured roughly 1.4s per command against 0.01s once the pin matches the installed major. pnpm 12 is also a native executable with no Node.js launcher, so it avoids the pnpm 11 failure mode where the native binary is only linked once a build script runs and pnpm quietly falls back to Node when that build is skipped. Update the CI workflow pins and the README prerequisite to match, and rewrite the README rationale for avoiding npm and Corepack installs, which no longer turns on pnpm 11's Node >= 22.13 bootstrap requirement. Verified on a clean install: pnpm install, pnpm build and pnpm test all exit 0, with 408 tests (402 passed, 6 skipped, 0 failed) and every lint job green. The lockfile change is confined to the pnpm provisioning entries, so no application dependency changes version. Closes #1173 Claude-Session: https://claude.ai/code/session_01CYgJmq2cxggmE8TGGiFDRi Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
* chore: upgrade @100mslive/hms-video-store to 0.14.7 Bumps the 100ms SDK used by the live events page from 0.10.6 (2023) to 0.14.7. Since 0.11 the core @100mslive/hms-video package is bundled into hms-video-store, so it drops out of the lockfile. The only code change is a guard in LiveService.renderScreenVideoToPeers: detachVideo now reads the SDK store, which only exists after a room has been joined, and the peers subscription fires on construction. Without the guard the service throws (unhandled rejection) on every page that injects it before join. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: upgrade @100mslive/hms-video-store to 0.15.0 Entire-Checkpoint: 01M27X1H3G7V7Y686T8BT20V5Q --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat: show event ID in info card on live page after joining * fix: show event ID card on keyboard focus * fix: improve event info card accessibility and close on Escape * fix: allow reopening event info card via click/Enter after Escape
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Approved the PR and merged it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 05-10-26
Developer Name: @geekyvaishnavi
Issue Ticket Number:-
PRs going for Sync-
Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
staging proofs